Repository navigation
fix(ci): create mutation testing output directory - #8174
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 3 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
- Create the mutants output dir before invoking cargo-mutants — after
rm -rf target/mutants,sh/rs/mutants.shnow runsmkdir -p target/mutants, so cargo-mutants' non-recursive output-directory creation succeeds on a clean checkout wheretarget/does not yet exist.
The fix matches upstream behavior: OutputDir::new in cargo-mutants only calls fs::create_dir on the --output path (verified for v25.3.1 and current main; nixpkgs pins v27.1.0), so it fails with "create output parent directory" when target/ is missing. Pre-creating the directory is explicitly supported, and the rm -rf immediately above still prevents cargo-mutants from rotating stale mutants.out results.
deepseek-v4.1-flash-1017 (free via Pullfrog for OSS) | 𝕏
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed head 88696e1.
No actionable findings. Creating the configured output directory after cleanup and before invoking cargo-mutants addresses the clean-checkout startup failure without changing mutation selection or exit-status handling.
Verification: GitHub-only static review of the diff and complete wrapper. I did not run cargo-mutants or the mutation suite.

Problem
The scheduled Mutants run fails before testing: cargo-mutants cannot create
target/mutantswhentargetdoes not exist on the clean runner.Approach
Create the output directory after clearing previous results.
Impact
Alternatives
Creating only
targetalso works; creating the configured output directory keeps this independent of its path.Validation
nix develop --command quest gate just cipassed.Review
Skipped local cross-vendor review for the trivial directory creation change.
Follow-ups
Interop's stale attribute assertion is already addressed by #8168. Other Nightly job failures remain outside this fix.
(Written by GPT-6.1 Sol)