Repository navigation
quest: finish PCR jump validation across recovery - #8200
Conversation
Quest-Claim: cdb5c9ef1351f758
The nightly TS workflow on main after #7981 passed every round trip and the long recovery arm, which holds padded faults to zero PCR flags. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kixelated
changed the title
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 26 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
kixelated
left a comment
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed head 3544250 against base d389cfb. No actionable findings in this two-file completion cleanup.
The deleted quest's remaining goal is PCR-jump recovery validation, and its parent Required entry is removed with it. The cited TS workflow run 42382332534 is successful, including the live, congested, overflowing, passthrough and long-recovery steps. The workflow directly exercises TS export and recovery, supporting this validation direction independently of browser interop.
Verification limits: GitHub-only inspection of the complete diff, workflow definition and published run/job results. I did not rerun tests, independently reproduce the reported local 261-test result, or re-audit the underlying PCR implementation. Rechecked open/non-draft state, full head/base and reviews immediately before posting.
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
- Deleted the finished PCR-jump quest —
quest/m1/ts-reliability/pcr-jump-flag.mdis removed; its validation work landed in #7981 and the remaining checks pass (nightlyTSrun 42382332534 onb5805859, 33 commits past #7981's merge, plusjust rs ts-recovery). No code, test, doc, or wire changes. - Dropped the parent's last
## Requiredentry — the link line and the now-empty heading leavequest/m1/ts-reliability/README.mdwith## Relatedfollowing the coverage-table prose, which matches other childless READMEs in the tree.
I verified the body's claims rather than taking the prose: #7981 and #7979 are merged, the cited nightly run includes the pair, live, congested, overflowing, passthrough, and TS long recovery steps, just rs ts-recovery selects the ignored long_* arms that assert .breaks(0), and a_skipped_group_flags_the_clock is present and unignored. The interop recipe (test/justfile:70, test/interop/interop.sh) exercises the session/media lanes, not the TS exporter, so skipping just test interop --all is justified. No leftover references to pcr-jump-flag remain, and the Quest check passed, so the required/edge tree is consistent.
deepseek-v4.1-flash-1017 (free via Pullfrog for OSS) ｜ 𝕏
Summary
Finishes the validation moq-dev/moq#7981 left behind. It deletes
quest/m1/ts-reliability/pcr-jump-flag.mdand itsRequiredlink from the TS reliability epic. No code changes.#7981 landed actual-PCR-jump flags. It kept this quest because
just test interop --allcould not run until moq-dev/moq#7979 landed (merged 2026-11-05). That matrix runs no TS export, so the TS recovery coverage the Goal names is the TS workflow plusjust rs ts-recovery. Both pass on main with #7981:b5805859aa6bf856c1a96ab3af89d45757de8e3d, which contains fix(mux)!: flag PCR discontinuities only when the clock jumps #7981: every step passed, including the pair, live, congested, overflowing, and passthrough round trips andTS long recovery(just rs ts-recovery). The long arm asserts.breaks(0), so faults padded on a continuing clock emit no PCR flag.d389cfb580(main):quest gate nix develop --command bash -c 'just rs ts-recovery && just rs test -p moq-mux --lib -E "test(/container::ts::(recovery_test|export_test|schedule)/)"'passed 1 + 260 tests. These covera_skipped_group_flags_the_clock, the declared and lost-marker discontinuity arms, and the disjoint-outage and handoff cases.The nightly interop workflow fails only in its
Harness regressionsstep (browser and harness unit tests), which runs no TS code.Choice made without asking: I took the nightly TS workflow and the recovery suite as the "remaining TS recovery interop coverage" and did not rerun
just test interop --all, because that matrix never exercises the TS exporter.Public API and wire
None.
Caused by
None. This is follow-up validation for #7981, not a bug fix.
Models
Size: S
Implementer: Claude Code, claude-opus-5-5, medium effort
Review
Codex
gpt-6.1-sol, high effort, session01a1b82a-7e31-7393-933c-3163fad0cb41round 1, reviewed head3544250ec9f95f3640436c98e0aabbf06cc06f0cagainst based389cfb580539dd6c07e2eff980547f02e92349d: 10/10, zero findings. The cleanup removes only the finished quest and its parent link, changes no runtime code or tests, and leaves no references to the deleted file. (Recorded by hand:quest reviewprintedrecord skippedbecause it resolved the worktree's branch, not the quest branch.)(Written by Claude Opus 5.5 with medium)