Repository navigation
quest: plan the stream-stopped tests' wall-clock deadline fix - #8217
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 12 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
kixelated
left a comment
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed head fb05e62.
No actionable findings. Removing these 100 ms deadlines preserves the actual assertions: all stop waiters receive code 42, and the already-polled waiter survives finishing and dropping its stream. Neither test asserts a latency bound. Using the runner's hang limit instead is a sound direction, with the quarantine and inventory entry removed together once implemented. The quarantine currently lives on #8088 rather than this base.
Verification limits: GitHub-only static review of both planning changes, both tests, #8088's quarantine and nextest configuration. No load reproduction or tests run. The default nextest hang budget is 60 seconds; the CI profile allows 120 seconds, and plain cargo test does not gain either bound. Rechecked open/non-draft state, full head/base and published reviews immediately before posting.
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
- New
[XS]flake child:quest/m0/test-flakes-2/quic-stream-stopped.mdplans dropping the 100 ms wall-clocktimeoutbounds inmoq-tokio'squic::driver::tests::stream_stoppedandstream_stopped_2so both await the stop events they assert, then un-ignoringstream_stopped, removing itssh/gh/test-inventory.allowentry, and deleting the quest. - Epic link: the child is appended to
quest/m0/test-flakes-2/README.md's## Requiredlist with matching title and summary.
Checks run against the tree: stream_stopped (rs/moq-tokio/src/quic/driver/tests.rs:1682) and stream_stopped_2 (:1707) do carry the 100 ms bounds; .config/nextest.toml sets slow-timeout = { period = "30s", terminate-after = 2 }, so the plan's "60 s terminate-after" is accurate and just test rs runs the workspace through sh/rs/nextest.sh; quest check passes (623 documents ok), as does sh/markdown.sh check. The quarantine the plan cites lives on #8088's head (sh/gh/test-inventory.allow:42), which is consistent with the plan calling itself a follow-up of that PR.
deepseek-v4.1-flash-1017 (free via Pullfrog for OSS) ｜ 𝕏
Plans the [XS] test-flakes-2 child for moq-dev/moq#8088's quarantine of moq-tokio's
quic::driver::tests::stream_stopped. A 100 ms wall-clocktimeoutaround the client fails on a loaded host, while nextest's 60 sterminate-afteralready bounds a hang. The quest drops the deadline so the test awaits its stop event, applies the same fix tostream_stopped_2's 100 ms bound, and un-ignores the test.Where #8088's other follow-ups went (maintainer, /quest-complete, 2026-11-07):
origin::Consumer::with_proxy, moq-quic's unused surfaces, andRendition.stats's type: folded into moq-dev/moq#8214's m2 api-shape plan.MoqRoute.instanceId()andMoqAudioEncoderFinishedrenames: already inquest/m3/ffi-exporter.md's Public API line, so nothing is added.Review
Codex gpt-6.1-sol (medium) via
quest review, session01a1b873-ca2c-7771-ab4e-d789da2e187e, round 1 onfb05e6226b(basefe00d62cc6): no findings.Decisions
quest/m0/test-flakes-2(maintainer, 2026-11-07).🤖 Generated with Claude Code
(Written by Claude Opus 5.5 with high)