Repository navigation
quest: smallvec maps into rust2-ts's runtime; fix rust2 links - #8245
Conversation
rust2 decided on 2026-11-07 to map smallvec into rust2-ts's runtime under its unsafe policy, so the model subset quest no longer drops it. Point the links at rust2's deleted ts-unsafe epic and ts.md at their replacements. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 19 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
kixelated
left a comment
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed 89d596c.
No actionable findings. Keeping smallvec in moq and mapping its safe API in rust2-ts matches the companion rust2 #667 plan and its unsafe-policy boundary. The replacement references point to the policy and model epic that now own that work. This avoids an unnecessary moq storage rewrite while leaving moq-specific unsafe/address changes in their existing quest.
The smallvec link depends on the still-open rust2 #667 landing, as documented. The pre-existing wasm2js-first versus translated-model direction conflict remains the explicit follow-up, not resolved by this link correction.
Verification limits: GitHub-only static review of both complete changed quests and the companion smallvec, model and unsafe-policy plans at rust2 #667's head. No implementation, tests, quest validation or translation benchmarks run. Rechecked open/non-draft state, full head and published reviews immediately before this COMMENT.
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
quest/m5/rs2ts-model-subset.md—smallvecleaves the drop list because rust2-ts maps it into its runtime, and the deleted ts-unsafe epic link now points at rust2's m3 unsafe policy.quest/m5/rs2ts-wasm2js.md— the deletedrust2 quest/m2/ts.mdlink now points at rust2's model epic.
Both replacement targets check out against rust2 main (the m3 README carries the unsafe policy, rule 2 wraps a common crate's unsafe at its safe API) and against rust2#667's head, where quest/m2/ts-model/smallvec.md exists. Nothing else in moq's tree mentions smallvec, so the split of the old drop list is complete.
ℹ️ Seven other rust2 quest links still 404 on rust2 main
These are pre-existing and outside this PR's stated scope, so not a blocker. Since this PR is the dead-link sweep, they are worth a line in the next audit: they point at rust2 quests removed in its m1 restructure on 2026-10-25.
Technical details
# Pre-existing dead rust2 quest links
## Affected sites
- `quest/m3/ffi-exporter.md:54` — `quest/m1/uniffi.md`
- `quest/m3/ffi-exporter.md:150` — `quest/m1/ffi-bytes.md`
- `quest/m3/ffi-exporter.md:151` — `quest/m1/kt-ffi-calls.md`
- `quest/m3/ffi-exporter.md:152` — `quest/m1/ffi-poll-protocol.md`
- `quest/m5/performance-survey/README.md:191` — `quest/m1/ffi-bytes.md`
- `quest/m5/performance-survey/README.md:192` — `quest/m1/ffi-poll-protocol.md`
- `quest/m5/performance-survey/README.md:193` — `quest/m1/kt-ffi-calls.md`
Each returns 404 from `raw.githubusercontent.com/moq-dev/rust2/main/`; the paths were
created in rust2 early and deleted when #41 restructured m1 under `quest/m1/ffi-export/`.
## Required outcome
- A follow-up either re-points each link at its current rust2 quest or epic, or unlinks the
completed quest it names, as this PR did for `quest/m2/ts.md`.deepseek-v4.1-flash-1017 (free via Pullfrog for OSS) ｜ 𝕏
Summary
This is the moq side of the rust2 quest audit, moq-dev/rust2#667. It makes two changes:
quest/m5/rs2ts-model-subset.mdsmallvecleaves the list of crates moq drops. rust2-ts maps it into its runtime instead, under rule 2 of rust2's unsafe policy, which wraps a common crate'sunsafeat its safe API.quest/m5/rs2ts-wasm2js.md: the link to rust2's deletedquest/m2/ts.mdnow points at its model epic.Decisions
Follow-ups
rs2ts-wasm2js.mdstill calls rust2-ts a "parallel research track" behind wasm2js. That contradicts rust2's 2026-11-01 decision, which made the translated model moq's browser route after moq removed WASM. Recommend: plan a rewording in moq's next audit.Models
Size: XS
Implementer: Claude Code, claude-opus-5-5, high effort
(Written by Claude Opus 5.5 with high effort)
🤖 Generated with Claude Code
Review
Rewritten by
quest reviewafter each round.01a1b918-7d84-7b51-9d1c-340d0524a14e, round 1The specified diff only aligns quest plans and references with recorded maintainer decisions, with no actionable defects found under the repository’s review rules.