Skip to content

quest: finish release-audio-group-cap - #8306

Merged
kixelated merged 2 commits into
mainfrom
quest/m0/release-audio-group-cap
Nov 9, 2026
Merged

kixelated merged 2 commits into
mainfrom
quest/m0/release-audio-group-cap

Conversation

@kixelated

@kixelated kixelated commented Nov 8, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Finishes the quest: the release fix moq-dev/moq#8118 shipped in @moq/publish 0.5.6 (moq-dev/moq#8213 merged; npm view @moq/publish version prints 0.5.6). This deletes the quest file and its link in quest/m0/README.md, clearing its Waiting item.

Public API: none. Wire: none.

Models

Size: XS
Implementer: Claude Code, claude-opus-5-5, unknown effort

🤖 Generated with Claude Code

(Written by Opus 5.5)

Review

Skipped at 29c8a4b: the diff only deletes a finished quest file and its one index link; quest check passes.

kixelated and others added 2 commits November 8, 2026 09:26
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated kixelated changed the title Release's audio encoder rolls groups before the cap quest: finish release-audio-group-cap Nov 8, 2026
@kixelated
kixelated marked this pull request as ready for review November 8, 2026 17:26
@coderabbitai

coderabbitai Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The README no longer lists the release audio encoder group-cap quest. The quest document was also removed.

Merge Risk: Minimal · up to 29c8a

The documentation removal presents no identified merge-blocking risk. No public API or runtime changes are described.

Pre-merge checks: Passed 5

Check name Status Explanation
Title check Passed The title "quest: finish release-audio-group-cap" matches the main change. The PR finishes the release-audio-group-cap quest by deleting its quest file and its index link in quest/m0/README.md. The ti…
Description check Passed The description is related to the changeset. It states that the quest is finished, that the release fix shipped in @moq/publish 0.5.6, and that the PR deletes the quest file and its link in quest/m0/R…
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "quest: finish release-audio-group-cap" matches the main change. The PR finishes the release-audio-group-cap quest by deleting its quest file and its index link in quest/m0/README.md. The title is short, specific, and names the quest that changed.

Full details: Description check

Explanation

The description is related to the changeset. It states that the quest is finished, that the release fix shipped in @moq/publish 0.5.6, and that the PR deletes the quest file and its link in quest/m0/README.md. It also gives the review status and states that there is no public API or wire change.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files.

Finishing Touches

Simplify code

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 440339c8-ce35-4a1a-866a-62cfe01204b1
Commits

Reviewing files that changed from the base of the PR and between e80b79a and 29c8a4b.

Files selected for processing: 2

  • quest/m0/README.md
  • quest/m0/release-audio-group-cap.md
Files with no reviewable changes: 1

  • quest/m0/release-audio-group-cap.md

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 0 remain after this review.

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes

  • Quest deletion — quest/m0/release-audio-group-cap.md is removed, matching the repo's normal completion shape (delete the file, drop its epic ## Required bullet, add no archive prose).
  • Index cleanup — the single ## Required line in quest/m0/README.md is removed; no other file in quest/, sh/, doc/, or .github/ referenced the quest path or title, and sh/gh/test-inventory.allow never named it.

Verified the tracked outcome rather than the deleted prose: #8118 (base release) merged as c4c4078293, #8213 (the 0.5.6 bump) merged as a2e6e1c3b4, release's js/publish/package.json reads 0.5.6, and npm published @moq/publish@0.5.6 at 2026-11-07T23:46:47Z. The published tarball's bundled encoder carries the net-cap roll verbatim (s.frames < n.Group.MAX_GROUP_FRAMES && s.bytes + o <= n.Group.MAX_GROUP_CACHE_BYTES), so the fix is genuinely shipped and not just version-stamped. quest/m2/unbounded-groups/, which owns the no-cap behavior on main, is untouched. Quest ran the full-tree quest check green; Check skipped as expected for a document-only diff.

Pullfrog  | View workflow run | Using deepseek-v4.1-flash-1017 (free via Pullfrog for OSS) | 𝕏

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed head 29c8a4b. No actionable findings in the completed quest and index-link removal.

Verified that #8118 and #8213 merged, release's @moq/publish manifest is 0.5.6, and the Release JS workflow for the version-bump merge completed successfully (run 42425626885).

Verification limits: GitHub-only review. The npm registry was not queried independently and no builds or tests were run.

@kixelated
kixelated added this pull request to the merge queue Nov 9, 2026
Merged via the queue into main with commit 4fa1558 Nov 9, 2026
13 of 14 checks passed
@kixelated
kixelated deleted the quest/m0/release-audio-group-cap branch November 9, 2026 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant