Repository navigation
chore(quest): clear the @moq/publish 0.5.6 wait, freeze web-transport's qmux at the cut - #8311
Conversation
… at the cut Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 3 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
kixelated
left a comment
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed b54061c. No actionable findings.
The four-file documentation change removes the completed audio-cap release wait and keeps the qmux publisher freeze ahead of the breaking cut's publication, with npm deprecation afterward. Verified #8118 and #8213 merged into release, @moq/publish is 0.5.6 at the release commit, and its Release JS workflow succeeded. The proposed web-transport freeze targets match its current release-plz defaults and explicit JS publisher steps.
Verification limits: static GitHub review only; no npm/crates.io registry queries or quest checks run. I did not independently re-audit the PR body's unrelated waiting items.
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
There was a problem hiding this comment.
ℹ️ One stale cross-reference in the epic README; nothing blocking.
Reviewed changes
- Deleted the completed m0 patch quest —
quest/m0/release-audio-group-cap.mdand its## Requiredbullet inquest/m0/README.md. Verified the tracked outcome:npm view @moq/publish versionprints0.5.6and #8213 merged intoreleaseon 2026-11-07. - Recorded the qmux freeze decision in both retire quests —
qmux-js-retire.mdandqmux-rs-retire.mdnow carry the 2026-11-08Decided ... ✅ freeze at the cutline and replace the old "maintainer has rights in web-transport" wait with an agent-opened freeze PR at the start of the cut, leaving only the npm deprecation and PR merge with the maintainer.
quest check on the PR head reports 590 documents ok, and no reference to release-audio-group-cap remains anywhere in the tree (including sh/gh/test-inventory.allow). Both decisions in the PR body landed in the changed files, and quest/m3/release/cut.md already gates publication on web-transport's release config, so the new ordering matches the cut.
ℹ️ Epic README summaries still place the qmux freeze after the first publish
quest/m3/release/README.md:43-44 still describes both quests as "once @moq/qmux publishes from js/qmux, deprecate ... and stop the second publisher" and "once qmux publishes from rs/qmux, moq-dev/web-transport stops publishing". That is the ordering this PR just reversed: the freeze now lands before the cut publishes. A later /quest-unblock run reading only the epic summary would wait for the wrong event.
Technical details
# Epic README still orders the qmux freeze after the first publish
## Affected sites
- `quest/m3/release/README.md:43` — "once `@moq/qmux` publishes from `js/qmux`, deprecate `@moq/web-socket-stream` and stop the second publisher"
- `quest/m3/release/README.md:44` — "once `qmux` publishes from `rs/qmux`, moq-dev/web-transport stops publishing the crate"
## Required outcome
- Both summaries state that the web-transport freeze PR merges at the start of the breaking cut, before the cut publishes, while the npm deprecation still follows the first `@moq/qmux` release.
- Keep them one-liners in the same voice as the neighbouring bullets.
## Open questions for the human
- Optional: whether the summaries should mention the freeze at all, or just point at the quests for the ordering detail.deepseek-v4.1-flash-1017 (free via Pullfrog for OSS) ｜ 𝕏
Problem
/quest-unblockon 2026-11-08 checked all 33 waiting items. One had cleared, and two maintainer waits needed a decision about when moq-dev/web-transport stops publishing qmux.Approach
quest/m0/release-audio-group-cap.mdonly waited on the 0.5.6 patch. moq-dev/moq#8213 merged intoreleaseon 2026-11-07, andnpm view @moq/publish versionprints0.5.6, so the quest is deleted withquest rm.@moq/web-socket-streamstays a maintainer item, since it needs npm rights.Decisions
Still waiting (checked 2026-11-08)
Every other item still holds. Notable evidence:
quest/m0/ci/hakari-followups.mdand moq-dev/moq#8171: the 2026-11-08 Nightly's Rust benchmark job was cancelled at 60 min again (job).quest/m0/interop-green/README.md: every scheduled Interop run since the 2026-10-21 pass has failed, most recently 42491651687.quest/m0/nightly/macos.md: 3 of 7 scheduled macOS runs are green.quest/m1/audio-jitter-target/capped-budgets.md: 4 of 7 nightlies.cachix-retire(2026-11-24 or later),mbx-r2-verify(2026-11-26 or later).crates-trusted-publisher,demo-sockets-deploy,runner-client-bump,smoke-bindings-rename,interop-runner-approval.bun lint, and rind-instant-acme.Impact
Public API: none. Wire: none. Quest tree only.
Models
Size: XS
Implementer: Claude Code, claude-opus-5-5, high effort
Review
Rewritten by
quest reviewafter each round.01a1bc64-7b43-7943-8f41-19f4f705cf98, round 1The documentation-only changes update release coordination plans and remove a completed quest, with no actionable defects found.🤖 Generated with Claude Code
(Written by Claude Opus 5.5 with high effort)