Skip to content

quest: delete content protection - #8332

Merged
kixelated merged 1 commit into
mainfrom
quest/delete-drm
Nov 9, 2026
Merged

kixelated merged 1 commit into
mainfrom
quest/delete-drm

Conversation

@kixelated

@kixelated kixelated commented Nov 9, 2026 •

Copy link
Copy Markdown
Collaborator

Deletes the content protection epic quest/m3/drm/ (README, import, mp4-atom, bindings) and quest/m5/drm-playback.md, plus their links from the m3 and m5 milestone READMEs.

Why: no in-tree player can play protected content (WebCodecs can't decrypt, EME needs MSE which <moq-watch> removed, native has no CDM), so the hang drm section, MSF contentProtections, import, and bindings would be surface with no consumer. Revisit when someone needs it. The implementing PRs #8285 and #7916 were already closed; the quest label was removed from #7766.

Public API / wire impact: none (quest docs only). Review skipped: deletion-only quest diff. quest check passes.

🤖 Generated with Claude Code

(Written by Claude Opus 5.5)

Review

Skipped at 7d65bab: the diff only deletes finished-by-decision quest files and their index links; quest check passes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 11 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: bf2f2144-852c-4728-b833-834be838dbd5
Commits

Reviewing files that changed from the base of the PR and between 4bdf10f and 7d65bab.

Files selected for processing: 7

  • quest/m3/README.md
  • quest/m3/drm/README.md
  • quest/m3/drm/bindings.md
  • quest/m3/drm/import.md
  • quest/m3/drm/mp4-atom.md
  • quest/m5/README.md
  • quest/m5/drm-playback.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes

  • Content protection epic deleted — removes quest/m3/drm/ (README.md, import.md, bindings.md, mp4-atom.md) and quest/m5/drm-playback.md, plus the two milestone bullets that listed them.
  • No survivors left behind — a repo-wide search finds no link, ## Required edge, sh/gh/test-inventory.allow entry, or prose gate referencing the deleted quests, and every /quest/... link in the edited milestone READMEs still resolves.
  • Bookkeeping matches the decision — #7766 is closed with its quest label removed, and both cited implementing PRs (#8285, #7916) are closed unmerged, so nothing is left pointing at work that no longer exists. quest check --base origin/main --branch pr-8332 reports 596 documents ok.

Pullfrog  | View workflow run | Using deepseek-v4.1-flash-1017 (free via Pullfrog for OSS) | 𝕏

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed head 7d65bab. No actionable findings in this planning-document removal.

The content-protection epic, its three child plans and deferred browser-playback plan are removed together with both milestone index entries. This retires planned work without changing runtime code, public APIs or wire behavior; the related implementation PRs #7916 and #8285 are closed.

Verification limits: GitHub-only static review of the full seven-file diff and related PR state. No builds, tests or repository-wide link checker run.

@kixelated
kixelated added this pull request to the merge queue Nov 9, 2026
Merged via the queue into main with commit 1ab909f Nov 9, 2026
10 checks passed
@kixelated
kixelated deleted the quest/delete-drm branch November 9, 2026 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant