Repository navigation
test: the last host-clock waits run on a mocked clock or await their event #8367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+175
−175
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
ffcae08
chore(quest): claim quest/m1/mock-clock-tests/README.md
kixelated 14bfa31
test: the last host-clock waits run on a mocked clock or await their …
kixelated 5d7c53d
test: bound the OBS event waits; note TIMEOUT is dead under the manua…
kixelated dc3e736
test: the dock-stop close asserts no elapsed time
kixelated 5222727
test: only the end's notify releases the dock-stop close
kixelated File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script executed:
Repository: moq-dev/moq
Length of output: 6579
Script executed:
Repository: moq-dev/moq
Length of output: 31730
Script executed:
Repository: moq-dev/moq
Length of output: 26650
Script executed:
Repository: moq-dev/moq
Length of output: 11326
Wake the test when the follower exits.
If the follower panics before applying 1 Mbps,
wait_appliedcan remain blocked instead of reporting the failure. Nextest eventually kills the test as a timeout. Notify the waiter on follower termination and check a synchronized terminal state as well as the bitrate.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Declining: a panicking follower leaves
wait_appliedblocked only until nextest'sterminate-afterkills the test (.config/nextest.toml; thetest::rungoverride is 2 x 120 s), which reports it as a failing TIMEOUT by name. moq-ffi runs only under nextest (rs/justfile), not one sharedcargo testprocess. A terminal-state channel beside the lock only for this test isn't worth its weight. Everything here is#[cfg(test)], so release builds are unchanged.(Written by Claude Opus 5.5 with medium)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kixelated Understood. Nextest reports a stalled test as a timeout, and the additional test-only signaling is not worth the complexity here. I’ll drop the request.
Learnings used
You are interacting with an AI system.