[kixelated]

Plans quest/m2/cluster-routing/routes/node-creation-order.md, a follow-up of moq-dev/moq#8325.

Summary

The lite-07 route node, and the feeder that tells it which routes this node serves itself, behave differently depending on which handle or code path creates them first. #8325 found that creating the node at session start makes room/.server/bob unroutable in three socket:: tests, and worked around it by reading node_id() without creating the node. This quest finds and fixes the root cause, so creation order stops mattering.

Verified against #8325's branch and main (10772522a5), with corrections to the follow-up as it was reported:

• Nothing reads route_node() at session start on either branch, and no cluster code sets the route node. feat(net,relay): a lite-07 endpoint declares its own Node ID in SETUP, so a relay refuses a session with itself #8325's SETUP reads node_id() (lite/session.rs:270-276 on its branch) specifically to avoid creating the node. The bug is latent: the node is created lazily by whichever route-layer call comes first (origin.rs:7177, called from publisher/routed.rs:165, subscriber/routed.rs:120/:799, and publisher.rs:210/:3792).
• create_route_node (origin.rs:7189-7230) builds the feeder from the creating handle with ..self.clone(). That keeps per-handle fields such as proxy, pool, cache duration, max hops, tasks, and timers. It does not carry a stale node: the node is built fresh from the origin's hop. Whether an inherited field explains the three failing tests is not yet known, so the quest makes reproducing them the first step.

Decisions

• ✅ Milestone m2, under quest/m2/cluster-routing/routes/ (rejected: m1; dropping it). Maintainer, 2026-11-09, /quest-complete follow-up of feat(net,relay): a lite-07 endpoint declares its own Node ID in SETUP, so a relay refuses a session with itself #8325.

Choices made without asking

• Sized M: the fix is probably small, but it needs a reproduction and root-cause work first.
• No Required on feat(net,relay): a lite-07 endpoint declares its own Node ID in SETUP, so a relay refuses a session with itself #8325's quest: this quest reproduces the bug on main by creating the node early. It does not depend on feat(net,relay): a lite-07 endpoint declares its own Node ID in SETUP, so a relay refuses a session with itself #8325 merging.

Impact

Public API: none. Wire: none. Planning only.

Models

Size: XS
Implementer: Claude Code, claude-opus-5-5, medium effort

🤖 Generated with Claude Code

(Written by Claude Opus 5.5 with medium effort)

Review

Rewritten by quest review after each round.

• Reviewer: Codex, gpt-6.1-sol, low effort
• Session: 01a1c2a7-ffb0-75d3-8abc-f42ee09755cd, round 1
• Head: 76597e7
• Base: origin/main at 147327e
• Score: 10/10, The change only documents a follow-up quest, changes no runtime behavior, and has no actionable defects.
• Findings: none

[kixelated]

Automated review by review (OpenAI)

Reviewed head: 76597e7

No actionable defects found in this planning-only change. Reproducing the early-creation failure before choosing a fix, then proving equivalent routing across creation orders and handle settings, is the right direction. The source confirms that create_route_node builds the feeder cursors from the calling consumer while resetting its routing filters; inherited state remains a hypothesis, not an established cause.

Verification: read the complete quest, the relevant origin construction code, the socket test setup, the related acceptance plan, and #8325's reported regression. Static GitHub review only; I did not run quest context, tests, or independently reproduce the failure.

[pullfrog]

ℹ️ Minor suggestions only — plan is factually solid against main; two small consistency fixes.

Reviewed changes

• New quest node-creation-order.md — plans making the lite-07 route node and its own-claims feeder independent of which handle or path creates them first, with a reproduce-first Plan and a fix in create_route_node.

Every code reference checks out against main (ecfa75a): route_node at origin.rs:7177, create_route_node at :7189, Producer::with_proxy at :2235, the five route-layer call sites, the socket.rs:307/344/371/392 test lines, the node_id() block at session.rs:271-276 on #8325's head, and the 10772522a5 base (behind_by: 0). The corrections to #8325's field list (stats and interest are reset, not inherited) match the source. No quest in the tree overlaps this one. The m2 placement is a recorded maintainer decision and matches the epic's milestone, so it is not raised.

ℹ️ The routes epic's ## Required list omits the new quest

quest/m2/cluster-routing/routes/README.md:538-544 lists all five existing children with a one-line summary each, and the new quest is the only one missing. The validator does not require the entry (directory membership reaches it either way), but recent quest PRs (#8376, #8379) both added the bullet when adding a child.

Technical details

# Add the new quest to its epic's Required list

## Affected sites
- `quest/m2/cluster-routing/routes/README.md:538-544` — `## Required` lists `availability.md`, `js.md`, `acceptance.md`, `browser-proof.md`, `playwright-pin.md`, but not `node-creation-order.md`.

## Required outcome
- The routes epic lists the new quest like its siblings, so the epic's work list stays complete.

## Suggested approach (optional)
- One bullet opening with the root-absolute link and a one-sentence summary in sibling style, e.g. `- [The route node behaves the same whoever creates it](/quest/m2/cluster-routing/routes/node-creation-order.md) - the lite-07 route node and its own-claims feeder do not depend on which handle creates them first`.

ℹ️ The PR body's implementer size contradicts the quest's

The body's Models section says Size: XS while the quest title is # [M] and the body's own Choices say "Sized M". Sibling quest PRs (#8376 M, #8377 S, #8379 XS) all match their title's bracket, so the XS here likely mis-sizes the implementer run for what the doc describes as needing a reproduction and root-cause work first.

Technical details

# Align the Models size with the quest title

## Affected sites
- PR body, `## Models` — `Size: XS`.
- `quest/m2/cluster-routing/routes/node-creation-order.md:1` — `# [M] The route node behaves the same whoever creates it`.

## Required outcome
- The Models section states `Size: M`, matching the quest's title and the body's "Sized M" choice.

  ^{｜ Fix all ➔ ｜ Fix 👍s ➔ ｜ View workflow run ｜ Using deepseek-v4.1-flash-1017 (free via Pullfrog for OSS) ｜ 𝕏}

[pullfrog]

This candidate cannot be the cause: Consumer::hop is copied from the Producer it was consumed from (rs/moq-net/src/model/origin.rs:7126) and is the origin's configured hop, so every handle on the origin carries the same value, and create_route_node rebuilds horizon from Horizon::default() plus NodeFilter::Own, which discards any exclude a session set. Neither the node's identity nor an exclusion can depend on when the session starts, so the reproduction need not spend time ruling this one out — dropping it (or replacing it with a handle-derived field that actually differs, such as proxy or preference) would keep the list of candidates worth checking.

[coderabbitai]

No actionable comments were generated in the recent review.

Walkthrough

Added a planning document for the route-node creation-order issue. It describes the reported failures, current lazy-creation paths, candidate causes, and proposed investigation and testing steps. The document records the m2 milestone decision and states that the change does not alter the public API or wire format.

Merge Risk: Minimal · up to 76597

The planning document introduces no actionable merge-blocking risk.

Pre-merge checks: 5

Check name	Status	Explanation
Title check		The title clearly identifies the planning work and the route node’s creation-order dependence.
Description check		The description explains the route node issue, the investigation plan, and the planning-only scope of the changeset.
Docstring Coverage		No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Finishing Touches

Simplify code

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

Recent review info

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: 2260a59f-38ae-4afb-be7a-5e1428596aff

Commits

Reviewing files that changed from the base of the PR and between 1077252 and 76597e7.

Files selected for processing: 1

• quest/m2/cluster-routing/routes/node-creation-order.md

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 0 remain after this review.