Skip to content

Simplify MoQ dock: full-width inputs and connection status#42

Merged
kixelated merged 1 commit into
mainfrom
claude/magical-mirzakhani-ee5815
Jun 19, 2026
Merged

Simplify MoQ dock: full-width inputs and connection status#42
kixelated merged 1 commit into
mainfrom
claude/magical-mirzakhani-ee5815

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Follow-up to #41.

Changes

  • Full-width inputs — URL and Broadcast-name fields now span the dock width (set QFormLayout::AllNonFixedFieldsGrow; the macOS default keeps fields at size-hint width).
  • Renamed "Broadcast path" → "Broadcast name".
  • Removed the Statistics box — it surfaced OBS-output counters (bitrate, duration, dropped frames, etc.), not data libmoq exposes. Replaced with a single connection indicator: Disconnected → Connecting… → Connected, driven by the session-connect state libmoq actually reports (via the output's connect time).
  • Use concrete stylesheet colors — Qt style sheets don't support the palette() function, so the prior color: palette(mid) was silently dropped (which is why the status text was hard to see).

Built and verified loading in stable OBS 31.1.2.

🤖 Generated with Claude Code

Make the URL/name inputs span the full dock width (set the form's field
growth policy, which defaults to size-hint width on macOS). Rename the
"Broadcast path" field to "Broadcast name".

Drop the statistics box, which surfaced OBS-output counters rather than
anything libmoq exposes. Replace it with a single connection indicator
(Disconnected / Connecting / Connected) driven by the session-connect
state libmoq actually reports. Use concrete stylesheet colors since Qt
style sheets don't support the palette() function.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 18, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@kixelated, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 45 minutes and 3 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: acc58bd2-b45d-4737-9e72-6912a13edb16

📥 Commits

Reviewing files that changed from the base of the PR and between 47bead8 and a163573.

📒 Files selected for processing (2)
  • src/moq-dock.cpp
  • src/moq-dock.h
✨ Finishing Touches
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch claude/magical-mirzakhani-ee5815

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@kixelated kixelated merged commit 4dbe6bc into main Jun 19, 2026
3 of 6 checks passed
kixelated added a commit to moq-dev/moq that referenced this pull request Jun 19, 2026
Port github.com/moq-dev/obs#42 into the vendored copy:
- Full-width URL and Broadcast-name fields (QFormLayout::AllNonFixedFieldsGrow).
- Rename "Broadcast path" to "Broadcast name".
- Drop the Statistics box (it showed OBS output counters, not libmoq data) in
  favor of a Disconnected / Connecting / Connected indicator driven by the
  session-connect state libmoq reports.
- Use concrete stylesheet colors; Qt style sheets ignore the palette() function.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant