Skip to content

quest: plan land follow-ups from moq's 2026-10-31 /quest-complete - #318

Merged
moq-bot[bot] merged 1 commit into
mainfrom
quest-plan/moq-2026-10-31-land
Oct 31, 2026
Merged

moq-bot[bot] merged 1 commit into
mainfrom
quest-plan/moq-2026-10-31-land

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Plans the quest-tool follow-ups that the 2026-10-31 moq-dev/moq /quest-complete run handed back. They come from about 80 queued PRs landing through quest land in one day.

Changes

  • m0/host-land/triage.md [M]: when a batch fails, the fixer reads the failure before anything is ejected.
    • It blames the PR that caused the failure and ejects only that PR, then requeues the rest.
    • When blame is unclear, it checks the base tip alone. A red base halts the queue.
    • A new gate that fails on base content blames the PR that adds the gate.
    • It ejects the whole batch only when it can't tell.
    • Bisection stays gone, and the ejection comment keeps the failing module's output.
  • m0/host-land/fixer-survives.md [S]: the fixer survives an ejection instead of crashing with exit 101 (cargo_cyclonedx flood), exit 143, or "disappeared". It recognises collateral PRs, and triage requires it.
  • m0/land-head-moved.md [S]:
    • The gate's own base-merge push no longer counts as a moved head.
    • A PR stopped by a batch-mate gets its own reason.
  • m0/land-queue-checks.md [S]: when a PR is queued, it is checked for conflicts against the other queued PRs, and its quest links against main.
  • m0/land-mergeability.md [XS]: land merges locally with the quest driver instead of trusting GitHub's stale mergeability.
  • m0/required-heading.md [XS]: the merge driver drops a ## Required heading whose list it empties.
  • m0/land-priority.md [S]: cheap checks get a bounded wait, and landing gets priority in the gate.
  • m1/status-landing.md [XS]: quest status drops its stale landing-stopped line, and no longer shows a cancelled run as failing.
  • m0/review-login.md (edited): the "not logged in" error names the CLAUDE_CONFIG_DIR profile it checked. moq-dev/quest#316 covers the environment-credential part, and whichever of the two lands second keeps only the 2026-10-31 paragraph.

Decisions

Decided 2026-10-31 by the user in the moq-dev/moq /quest-plan session:

  • Land blame, asked as "The fixer triages a failing batch before ejecting":
    • ✅ Yes, as restated. The user refined it: "The fixer reads the failure, tries to identify the PR that caused it, and only ejects that PR. If it can't figure it out, it ejects all PRs". The question started from the user's "could the fixer not figure it out? It should run on each batch before ejecting, instead of wasting CI on bisection?"
    • Fixer only diagnoses
    • Base check in gate
  • Where the follow-ups go: ✅ a moq-dev/quest PR. Rejected: one umbrella quest, or tracking them in moq's quest/m0/ci.
  • Milestones, asked per quest: ✅ m0 for triage, fixer-survives, head_moved, queue checks, mergeability, required-heading and land priority. ✅ m1 for status-landing.

Choice made without asking: head_moved, queue checks, mergeability, required-heading and land priority sit at the m0 root, not under host-land. The queue-checks quest overlaps helpers/queue-siblings.md, and whichever lands first, the other drops what's already covered.

Review

Codex (gpt-6.1-sol, medium) reviewed head 5a1bd2c against origin/main dc8008b: 0 findings.

🤖 Generated with Claude Code

(Written by Claude Opus 5.5)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 31, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 52 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 0d6428ca-40eb-4ab6-8f08-5787a7147abe
Commits

Reviewing files that changed from the base of the PR and between dc8008b and 5a1bd2c.

Files selected for processing: 12
  • quest/m0/README.md
  • quest/m0/host-land/README.md
  • quest/m0/host-land/fixer-survives.md
  • quest/m0/host-land/triage.md
  • quest/m0/land-head-moved.md
  • quest/m0/land-mergeability.md
  • quest/m0/land-priority.md
  • quest/m0/land-queue-checks.md
  • quest/m0/required-heading.md
  • quest/m0/review-login.md
  • quest/m1/README.md
  • quest/m1/status-landing.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@moq-bot

moq-bot Bot commented Oct 31, 2026

Copy link
Copy Markdown
Contributor

quest land removed this pull request from the queue: required checks had not passed on its head when the gate ran: check (from app 15368); land it again once they pass.

@moq-bot moq-bot Bot removed the quest:merge label Oct 31, 2026
@kixelated
kixelated enabled auto-merge (squash) October 31, 2026 15:03
@moq-bot
moq-bot Bot merged commit 66a39b7 into main Oct 31, 2026
5 checks passed
@moq-bot
moq-bot Bot deleted the quest-plan/moq-2026-10-31-land branch October 31, 2026 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant