Skip to content

quest: plan keying review sessions by upstream branch - #485

Merged
kixelated merged 4 commits into
mainfrom
quest-plan/review-session-key
Nov 4, 2026
Merged

kixelated merged 4 commits into
mainfrom
quest-plan/review-session-key

Conversation

@kixelated

@kixelated kixelated commented Nov 4, 2026 •

Copy link
Copy Markdown
Collaborator

Plans quest/m0/review-session-key.md, the follow-up moq-dev/quest#474 suggested. Iterate agents on moq-dev/quest#464, moq-dev/quest#469, moq-dev/quest#472, and moq-dev/quest#474 reviewed from temporary local branches because another worktree held the PR branch. Since quest review keys sessions by the checked-out branch name, each started a new session, which resets the design checkpoint, or later resumed the wrong one.

Changes

  • New quest [S] Review sessions keyed by upstream branch in m0, ranked after Reviewer usage limits.
  • Base-branch upstream excluded (added in review): a local branch whose upstream is the review's base branch keys by its own name. Branches made from origin/main track it by default (23 local branches in the maintainer's clone, this PR's own included), so keying them by upstream would merge them all into one main session. This refines the implementation of the decided rule below; the decision itself is unchanged.

Decisions

Settled with the maintainer in /quest-complete on 2026-11-04:

  • What should the quest's goal be?
    • ✅ Key by upstream branch, plus skill guidance for a PR branch another worktree holds
    • Rejected: skill guidance only; key by PR number
  • Which milestone?
    • ✅ m0
    • Rejected: m1; m2

Review

Skipped on head cb07d3406dc14b7a7f12e5150fa1fc7d8a185439. The changes since the reviewed head are trivial. 6efcd769 turns one bare PR number in quest/m0/review-session-key.md into a link. cb07d340 merges origin/main, resolving a quest/m0/README.md conflict where main deleted the neighboring waiting-drafts row. The PR still adds that one row, ranked after Reviewer usage limits. main's changes to src/cli/review.ts only rename gitOutput to git, so the plan's description of sessionBranch and sessionFile still holds. just check, just test, and quest check --base origin/main pass on cb07d340.

Previous round: Codex gpt-6.1-sol (effort medium, as quest review reported) via quest review --base origin/main, round 1 on head b0899869705fec1076b192ffb908b7d190e66650, had no findings. Before that round, Claude Opus 5.5 checked the plan against src/cli/review.ts (sessionBranch, sessionFile). Sessions are keyed by --branch or git symbolic-ref --short HEAD and hashed into <git-common-dir>/quest/review/<digest>.json. A detached HEAD already requires --branch, so the plan's facts hold. That check found one gap, fixed in b0899869: the decided "upstream name when it has one" rule would key every branch that tracks origin/main as main. The quest's implementation guidance now excludes an upstream that is the base branch, and notes that review currently names the session before it resolves the default base.

Pullfrog on b0899869: #474 on quest/m0/review-session-key.md:17 was still bare. Fixed in 6efcd769. The PR number is now a link, written by hand because the suggested patch covered only line 17 and would have duplicated the start of line 18.

🤖 Generated with Claude Code

(Written by Claude Opus 5.5)

kixelated and others added 2 commits November 4, 2026 10:02
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated
kixelated marked this pull request as ready for review November 4, 2026 18:19
@coderabbitai

coderabbitai Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 25 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: c0e904a3-c57c-4922-98b2-63643d286810
Commits

Reviewing files that changed from the base of the PR and between c76df68 and cb07d34.

Files selected for processing: 2
  • quest/m0/README.md
  • quest/m0/review-session-key.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ No critical issues — one minor suggestion inline.

Reviewed changes — plan-only PR: one new quest file plus its README row; all factual claims checked directly against src/cli/review.ts and src/runner/workspace.ts.

  • New quest [S] Review sessions keyed by upstream branch (quest/m0/review-session-key.md) — keys a quest review session by the local branch's upstream branch name instead of the local branch name, so a temporary branch tracking the PR branch continues that PR's session; excludes an upstream that is the review's base so origin/main-tracking branches don't collapse into one main session.
  • README row in quest/m0/README.md — the quest at its chosen rank, next to Reviewer usage limits.

Verification: sessionBranch and sessionFile behave as the quest's Plan states (src/cli/review.ts:872, src/cli/review.ts:854), the session key is indeed named before the default base resolves (review.ts:898 vs fetchBase at review.ts:832-849), and the runner's kix-review/* branches have no upstream, so they keep keying by their own name (src/runner/workspace.ts:397-407). quest check passes (71 documents).

Pullfrog  | Fix all ➔ | Fix 👍s ➔ | View workflow run | Using glm-5.3-flash | 𝕏

Comment thread quest/m0/review-session-key.md Resolved
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated
kixelated added this pull request to the merge queue Nov 4, 2026
Merged via the queue into main with commit 05aebae Nov 4, 2026
10 checks passed
@kixelated
kixelated deleted the quest-plan/review-session-key branch November 4, 2026 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant