Skip to content

guide: the design checkpoint applies only when a third round reports findings #498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
moq-bot merged 1 commit into from
Nov 5, 2026
Merged

guide: the design checkpoint applies only when a third round reports findings #498

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion assets/CONTEXT.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ Where it says nothing, only a record on a PR whose author has write access count

Checkpoint the design across review rounds.
A review round is one `quest review` round, numbered within the branch's review session.
Every third round, stop before fixing more findings and reconsider the approach.
When a round whose number is a multiple of three reports findings, stop before fixing them and reconsider the approach; a clean round needs no checkpoint.
Findings that keep coming usually mean the approach is wrong, not the last fix: brainstorm other designs that would avoid the whole class of findings, favoring simpler ones, and compare them with the current one.
Report the alternatives and what remains, recommending to continue, rethink the approach, merge as is, or drop the PR, and let the user decide; a background agent leaves this under `## Waiting` rather than deciding it.
Record each design change, including a rethink the user picks, in a PR comment that starts with `Design change:`, and start the next review with `quest review --new`, which restarts the count.
Expand Down
2 changes: 1 addition & 1 deletion test/runner.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1064,7 +1064,7 @@ describe("prompts", () => {
expect(merge).toContain("Where the workflow says to run `quest wait`, call `wait`");
expect(merge).toContain("# The merge workflow");
// The skill's design checkpoint still reaches the maintainer.
expect(merge).toContain("Every third round");
expect(merge).toContain("a multiple of three reports findings");
});

test("carry earlier summaries and the latest answer", () => {
Expand Down