Skip to content

quest: plan three generic rules for the shared context #529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kixelated merged 1 commit into from
Nov 7, 2026
Merged

quest: plan three generic rules for the shared context #529

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions quest/m0/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,3 +105,4 @@ ownership-manifest design:
- [Agents get the dev shell from user settings](/quest/m0/user-dev-shell/README.md) - maintainers' own Claude and Codex settings load the dev shell; repositories drop dev-shell hooks, Quest worktree hooks, and `nix develop` instructions, and `quest init` writes no hooks
- [Session checkouts released](/quest/m0/session-checkouts.md) - a Claude session's own checkout is released when the session ends and reclaimed on resume
- [claude rm upstream report](/quest/m0/claude-rm-upstream.md) - posting approved: ask Claude Code to run `WorktreeRemove` instead of advising an unlock
- [Three generic rules in the shared context](/quest/m0/context-rules.md) - `quest context` adds matching conventions, never loosening a flaky test, and short names under a namespace
31 changes: 31 additions & 0 deletions quest/m0/context-rules.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
# [S] Three generic rules in the shared context

## Goal

`quest context` gives every repository three engineering rules that moq-dev/rust2 used to
carry itself, each said once in the section it belongs to:

- Match the code's existing conventions, patterns, and naming.
- Never pass a flaky test by loosening its assertion; fix the cause.
- Short names under a module namespace, rather than repeating the module in each name.

## Plan

[moq-dev/rust2#553](https://github.com/moq-dev/rust2/pull/553) replaced rust2's own copies
of the shared rules with `quest context`, dropping these because `assets/CONTEXT.md` had
no equivalent. Word each to fit its neighbors, such as "Name by role" under Public API and
the root-cause rule under Required, and follow the context's Prompting section.

Decided 2026-11-07 (maintainer, moq-dev/rust2 /quest-complete):

- Which dropped rules join the shared context?
- ✅ Match existing conventions, patterns, and naming
- ✅ Never pass a flaky test by loosening its assertion
- ✅ Short names under a module namespace
- Rejected: "keep the PR to one problem, no drive-by changes", which clashes with
fixing bugs in the code a PR touches and outdated docs inline
- Rejected: "if a skill's usage is unclear, offer to update it"
- Where does this quest go?
- ✅ m0 (recommended)
- m1
- m2