Skip to content

context: add three generic engineering rules - #588

Merged
kixelated merged 2 commits into
mainfrom
quest/m0/context-rules
Nov 9, 2026
Merged

kixelated merged 2 commits into
mainfrom
quest/m0/context-rules

Conversation

@kixelated

@kixelated kixelated commented Nov 9, 2026 •

Copy link
Copy Markdown
Collaborator

Adds the three rules moq-dev/rust2#553 dropped, finishing quest/m0/context-rules.md:

  • Required: the root-cause rule now covers flaky tests and names "looser assertion" as a forbidden workaround, instead of a separate line.
  • Guidelines: "Match the code's existing conventions, patterns, and naming."
  • Public API: "Name by role" gains short names under a module namespace, with an http::Client example.

assets/CONTEXT.md is 9,692 of the 10,000 character CONTEXT_LIMIT on main; moq-dev/quest#582 shortens it further. No room had to be made.

Choices made without asking: folding the flaky-test rule into the root-cause line to save characters, and the namespace example.

Public API / wire impact: none; hook context text only.

just check and just test pass.

Models

Size: S
Implementer: Claude, Opus 5.5, low effort

🤖 Generated with Claude Code

(Written by Claude Opus 5.5 with low effort)

Review

Rewritten by quest review after each round.

  • Reviewer: Codex, gpt-6.1-sol, medium effort
  • Session: 01a1c168-7f9d-73a2-9b64-bac448f3dfb1, round 1
  • Head: 721d332
  • Base: origin/main at 37963bf
  • Score: 10/10, The three requested rules are incorporated, the context remains below its 10,000-character limit, and the completed quest has no remaining references; no actionable defects were found.
  • Findings: none

Quest-Claim: 10d1947b07b9d20d
@pullfrog

pullfrog Bot commented Nov 9, 2026

Copy link
Copy Markdown

Pullfrog  | Review this ➔

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated kixelated changed the title Three generic rules in the shared context context: add three generic engineering rules Nov 9, 2026
@kixelated
kixelated marked this pull request as ready for review November 9, 2026 17:44
@coderabbitai

coderabbitai Bot commented Nov 9, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 33 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: f74acf23-f6d7-45f0-b72b-e0b48fde1a75
Commits

Reviewing files that changed from the base of the PR and between 37963bf and 721d332.

Files selected for processing: 2

  • assets/CONTEXT.md
  • quest/m0/context-rules.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed head: 721d332

No actionable findings in the reviewed changes.

Direction: the three requested rules are incorporated into the relevant existing sections without duplicating the root-cause or naming rules. The complete CONTEXT.md fetched at this head is 9,692 characters, below the 10,000-character limit defined in hooks.ts, so this change does not depend on #582 landing to fit.

Verification limits: GitHub-only static review of both changed files, the surrounding context, and hook limit/consumption. No repository code, tests, builds, or live hook execution performed. The visible check/queue/lifecycle jobs are skipped and CodeRabbit is neutral; the PR author's reported local checks were not independently rerun.

(Written by review (OpenAI))

@kixelated
kixelated added this pull request to the merge queue Nov 9, 2026
Merged via the queue into main with commit 969990d Nov 9, 2026
14 checks passed
@kixelated
kixelated deleted the quest/m0/context-rules branch November 9, 2026 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant