Skip to content

docs(agents): rely on quest context for shared rules - #305

Merged
kixelated merged 3 commits into
mainfrom
docs/quest-context
Nov 5, 2026
Merged

kixelated merged 3 commits into
mainfrom
docs/quest-context

Conversation

@kixelated

@kixelated kixelated commented Nov 3, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

rind's AGENTS.md and PROMPTING.md copied engineering rules shared by every moq-dev repo. moq-dev/quest#457 added quest context, which prints those shared rules plus a Prompting section, so the copies drift for no benefit.

Approach

  • AGENTS.md keeps only rind's own rules (backends, hostile input, constant time, sources, Wycheproof and aws-lc-rs testing, API misuse, wiping, aws-lc-rs benchmarks, adapter crates) and tells agents to run quest context alongside quest guide.
  • Drop PROMPTING.md; .claude/rules/prompting.md now points at Prompting in quest context. No other tracked file referenced PROMPTING.md.
  • Bump the quest flake input to 9277dc3413c9297ba12326e5ae4abeff7f2ff6be, the merge of moq-dev/quest#457.

Every dropped rule is covered by quest context or quest guide, except these generic ones, dropped as not rind-specific: "keep the PR to one problem", "match existing conventions", "AI comments carry no maintainer authority", "never pass a flaky test by loosening its assertion", "scrutinize every new exported item". The just ci-select line also goes: it is CI plumbing that only check.yml calls.

Impact

  • Docs and tooling only. No public API change.

Validation

  • nix develop --command quest context prints the shared context.
  • nix develop --command just check and just ci pass.

Alternatives

  • Keep copying the shared rules per repo. That is the drift this replaces.

Follow-ups

  • None.

Review

  • 9a496eb3fbbdd504a07368de5178cac096b94403: review skipped by the author as trivial (the reference line, reference wording, and the quest pin since the reviewed head).

quest review --base origin/main: Codex, gpt-6.1-sol, medium effort, head c86101f, round 1: no findings.

Update for moq-dev/quest#460

moq-dev/quest#460 made quest context the command agents run before any work, and quest guide quest-only (the context says when to run it). This push changes the AGENTS.md reference line to Quests: before any work, run `quest context` and follow it. and bumps quest to 4be350816f2a5c1157f799773ee1594f199fd9a7. The repository's checks pass on the new head.

🤖 Generated with Claude Code

(Written by Claude Opus 5.5)

`quest context` now prints the shared engineering rules and the Prompting
guidance, so AGENTS.md keeps only rind's own rules and PROMPTING.md goes.
Bump the quest flake input to the release that adds the command.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

Files ignored due to path filters: 1

  • flake.lock is excluded by !**/*.lock
Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 429e4727-9867-4c55-a57b-3cdacac1d1a2
Commits

Reviewing files that changed from the base of the PR and between 9a496eb and a4f0a32.

Files ignored due to path filters: 1

  • flake.lock is excluded by !**/*.lock

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review

No actionable comments were generated in the recent review.

Walkthrough

The project guidance in AGENTS.md is shorter and changes several development instructions, including when to run quest context. The prompting rule now refers to “Prompting in quest context,” and PROMPTING.md is deleted. The quest input in flake.nix points to a new revision.

Merge Risk: Minimal · previous review 9a496

The changes consolidate project guidance into quest without an established blocking defect. Mergeable subject to normal checks; the PR description should reflect the actual pinned revision.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title clearly summarizes the main change: agent documentation now relies on shared rules from quest context.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description check Passed The pull request description directly explains the documentation changes, removal of PROMPTING.md, quest flake update, and validation performed.
Finishing Touches

Simplify code

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: fc34fdb3-3903-4563-a217-966c50b4cd1b
Commits

Reviewing files that changed from the base of the PR and between 7eaba9d and 9a496eb.

Files ignored due to path filters: 1

  • flake.lock is excluded by !**/*.lock
Files selected for processing: 4

  • .claude/rules/prompting.md
  • AGENTS.md
  • PROMPTING.md
  • flake.nix
Files with no reviewable changes: 1

  • PROMPTING.md

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes

This run read the complete diff of docs/quest-context against main (1 commit) and verified the PR body's coverage claim against the upstream artifact the new instructions now depend on: assets/CONTEXT.md at the pinned quest rev 9277dc3, plus the consumers of every touched file.

  • AGENTS.md slims to rind's own rules: keeps the single-backend compile, hostile input, constant time + ctgrind, formally verified sourcing, Wycheproof/aws-lc-rs testing, API misuse, aws-lc-rs behavior, secret wiping, benchmark, and adapter-crate rules plus the just check/just fix block; drops the shared generic rules and points agents at quest context beside quest guide.
  • PROMPTING.md deleted, folded upstream: its content lives in the Prompting section of assets/CONTEXT.md, and .claude/rules/prompting.md now points there; no tracked file references PROMPTING.md anymore.
  • quest flake input bumped to 9277dc3, the merge of moq-dev/quest#457, which is verified in the quest CLI source: main.ts registers the context command and skills.ts bundles assets/CONTEXT.md (Required/Important/Guidelines/Public API tiers plus Prompting). The lock's new nixpkgs-opencode and quest-pinned entries mirror upstream quest's flake.
  • just ci-select doc line removed: the recipe stays in the justfile and its only caller (check.yml:34) is untouched, so nothing dangles.

The coverage claim checks out. I compared every rule the old AGENTS.md carried against assets/CONTEXT.md at the pinned rev: each rule named in the PR body is covered verbatim or deliberately dropped upstream, and the few not named there (ask interactively, scratch in .tmp/, follow-ups as quests) are the exact set quest#457 already chose to drop from the shared context; rind's CONTRIBUTING.md still carries the follow-ups-as-quests rule, so that one survives in the repo. The new AGENTS.md reference line matches the string quest init now writes, so a future quest init won't fight it.

Pullfrog  | View workflow run | Using glm-5.3-flash | 𝕏

quest#460 moved the rules every task needs into `quest context`; `quest guide` is now only for quest work, and the context says when to run it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes

This run covered the delta since the prior Pullfrog review: one commit (9a496eb, 3 files, comments plus the flake pin) after c86101f.

  • Repointed the quest reference line: AGENTS.md now ends with Quests: before any work, run \quest context` and follow it., matching [moq-dev/quest#460](https://github.com/moq-dev/quest/pull/460)'s "always quest context, quest guideonly for quest work". Nothing dangles: no tracked file references the deletedPROMPTING.md, and CONTRIBUTING.md`'s Reviews rules were not moved, so the commit correctly leaves that file untouched.
  • Bumped the quest pin to 4be3508 in both flake.nix and flake.lock, the merge of moq-dev/quest#460. Verified the dependency at that rev: quest context is still registered in src/cli/main.ts:1186 and prints assets/CONTEXT.md, which carries the shared rules plus the Prompting section this PR relies on, so the coverage claim the first review verified at 9277dc3 still holds.

ℹ️ The PR body claims a CONTRIBUTING.md change this commit does not make

The Update for moq-dev/quest#460 section says the push repoints CONTRIBUTING.md references to the moved Reviews rules, but the diff touches only AGENTS.md, flake.nix, and flake.lock, and nothing in the tree references a rule that moved. Worth correcting that sentence so the body records what the commits actually do.

Pullfrog  | View workflow run | Using glm-5.3-flash | 𝕏

@kixelated
kixelated added this pull request to the merge queue Nov 5, 2026
Merged via the queue into main with commit 808b04e Nov 5, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant