Repository navigation
docs(agents): rely on quest context for shared rules - #305
Conversation
`quest context` now prints the shared engineering rules and the Prompting guidance, so AGENTS.md keeps only rind's own rules and PROMPTING.md goes. Bump the quest flake input to the release that adds the command. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes.
|
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
This run read the complete diff of docs/quest-context against main (1 commit) and verified the PR body's coverage claim against the upstream artifact the new instructions now depend on: assets/CONTEXT.md at the pinned quest rev 9277dc3, plus the consumers of every touched file.
AGENTS.mdslims to rind's own rules: keeps the single-backend compile, hostile input, constant time + ctgrind, formally verified sourcing, Wycheproof/aws-lc-rs testing, API misuse, aws-lc-rs behavior, secret wiping, benchmark, and adapter-crate rules plus thejust check/just fixblock; drops the shared generic rules and points agents atquest contextbesidequest guide.PROMPTING.mddeleted, folded upstream: its content lives in the Prompting section ofassets/CONTEXT.md, and.claude/rules/prompting.mdnow points there; no tracked file referencesPROMPTING.mdanymore.- quest flake input bumped to
9277dc3, the merge of moq-dev/quest#457, which is verified in the quest CLI source:main.tsregisters thecontextcommand andskills.tsbundlesassets/CONTEXT.md(Required/Important/Guidelines/Public API tiers plus Prompting). The lock's newnixpkgs-opencodeandquest-pinnedentries mirror upstream quest's flake. just ci-selectdoc line removed: the recipe stays in the justfile and its only caller (check.yml:34) is untouched, so nothing dangles.
The coverage claim checks out. I compared every rule the old AGENTS.md carried against assets/CONTEXT.md at the pinned rev: each rule named in the PR body is covered verbatim or deliberately dropped upstream, and the few not named there (ask interactively, scratch in .tmp/, follow-ups as quests) are the exact set quest#457 already chose to drop from the shared context; rind's CONTRIBUTING.md still carries the follow-ups-as-quests rule, so that one survives in the repo. The new AGENTS.md reference line matches the string quest init now writes, so a future quest init won't fight it.
glm-5.3-flash | 𝕏
quest#460 moved the rules every task needs into `quest context`; `quest guide` is now only for quest work, and the context says when to run it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
This run covered the delta since the prior Pullfrog review: one commit (9a496eb, 3 files, comments plus the flake pin) after c86101f.
- Repointed the quest reference line:
AGENTS.mdnow ends withQuests: before any work, run \quest context` and follow it., matching [moq-dev/quest#460](https://github.com/moq-dev/quest/pull/460)'s "alwaysquest context,quest guideonly for quest work". Nothing dangles: no tracked file references the deletedPROMPTING.md, andCONTRIBUTING.md`'s Reviews rules were not moved, so the commit correctly leaves that file untouched. - Bumped the quest pin to
4be3508in bothflake.nixandflake.lock, the merge of moq-dev/quest#460. Verified the dependency at that rev:quest contextis still registered insrc/cli/main.ts:1186and printsassets/CONTEXT.md, which carries the shared rules plus the Prompting section this PR relies on, so the coverage claim the first review verified at9277dc3still holds.
ℹ️ The PR body claims a CONTRIBUTING.md change this commit does not make
The Update for moq-dev/quest#460 section says the push repoints CONTRIBUTING.md references to the moved Reviews rules, but the diff touches only AGENTS.md, flake.nix, and flake.lock, and nothing in the tree references a rule that moved. Worth correcting that sentence so the body records what the commits actually do.
glm-5.3-flash | 𝕏

Problem
rind's
AGENTS.mdandPROMPTING.mdcopied engineering rules shared by every moq-dev repo. moq-dev/quest#457 addedquest context, which prints those shared rules plus a Prompting section, so the copies drift for no benefit.Approach
AGENTS.mdkeeps only rind's own rules (backends, hostile input, constant time, sources, Wycheproof and aws-lc-rs testing, API misuse, wiping, aws-lc-rs benchmarks, adapter crates) and tells agents to runquest contextalongsidequest guide.PROMPTING.md;.claude/rules/prompting.mdnow points at Prompting inquest context. No other tracked file referencedPROMPTING.md.Every dropped rule is covered by
quest contextorquest guide, except these generic ones, dropped as not rind-specific: "keep the PR to one problem", "match existing conventions", "AI comments carry no maintainer authority", "never pass a flaky test by loosening its assertion", "scrutinize every new exported item". Thejust ci-selectline also goes: it is CI plumbing that onlycheck.ymlcalls.Impact
Validation
nix develop --command quest contextprints the shared context.nix develop --command just checkandjust cipass.Alternatives
Follow-ups
Review
9a496eb3fbbdd504a07368de5178cac096b94403: review skipped by the author as trivial (the reference line, reference wording, and the quest pin since the reviewed head).quest review --base origin/main: Codex, gpt-6.1-sol, medium effort, head c86101f, round 1: no findings.Update for moq-dev/quest#460
moq-dev/quest#460 made
quest contextthe command agents run before any work, andquest guidequest-only (the context says when to run it). This push changes theAGENTS.mdreference line toQuests: before any work, run `quest context` and follow it.and bumps quest to4be350816f2a5c1157f799773ee1594f199fd9a7. The repository's checks pass on the new head.🤖 Generated with Claude Code
(Written by Claude Opus 5.5)