Repository navigation
chore(quest): drop bench-host-lock, which #399 already delivers - #417
Conversation
Quest-Claim: 08bbed4c18460125
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Your OpenCode Go account is out of credit. Top it up, then re-trigger Pullfrog. OpenCode Go's response
|
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 58 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed e6b3831. No actionable findings in the quest deletion and matching index removal. The existing collect_host uses a unique temporary source directory, wraps the build/benchmark/build-cost run in quest gate --host, and cleans up only that source directory, supporting the stated direction of retaining queued host access rather than adding skip-as-busy behavior.
Verification: GitHub-only static inspection of both changed files and the relevant collection code. I did not run quest check, concurrent collections, or verify the gate implementation on each host.

Proposes dropping quest/m2/speed/bench-host-lock.md: main already delivers its Goal.
Problem
The quest was planned at 18:58 UTC on 2026-11-06, in #401, after one
collect --host kixtopdeleted the shared copy that #399's collection was building from. Its plan was to extend #397's VPSflockto every host and skip a held host as busy.#399 then merged at 20:26 UTC and fixed that clobbering another way (
admin/bench-report,collect_host):mktemp -dcopy and removes only that copy. No collection clears a path another one uses.admin/build-costall run underquest gate --host, which holds the whole host, local or remote. A second collection's run waits until the first one ends, so the sharedtargetdirectory never has two runs at once.The only part of the Goal that main does differently is that a second collection waits for the host instead of recording it as busy. #399 was reviewed and merged with the wait, after this quest was planned, so this PR takes that as the newer decision.
Approach
quest rmdeletes the quest and its link from quest/m2/speed/README.md.Waiting
quest gate --hostalready stop any collection from deleting or measuring over another one, on every host. Waiting returns a measurement where a skip would return only a busy record. To accept, mark this PR ready and merge it.collectwould check whether the host is held and record it as busy instead of queuing. Every host would need a lock that is visible from outsidequest gate, and macOS ships noflock(1). Choose this by commenting here, and the quest gets rewritten in this PR.Notes for #397
#397 conflicts with main in
admin/bench-report(git merge-treereports a content conflict). Itshost_scriptstill clears the shared{work}/srcand{work}/result.json. When it merges main, it should keep #399's per-collection copy and gate. Only the VPS lease, which the hosts' other tooling also takes, stays specific to #397. No change here depends on that.Impact
Models
Size: XS
Implementer: Claude Code, claude-opus-5-5, high effort
Review
Skipped: a quest deletion produced by
quest rm, with no code, too trivial to need a review.quest checkpasses.(Written by Claude Opus 5.5)
🤖 Generated with Claude Code