Skip to content

chore(quest): plan an Ed25519 verify benchmark that times every library the same way - #427

Merged
moq-bot[bot] merged 2 commits into
mainfrom
quest/m2/speed/ed25519-verify-bench
Nov 7, 2026
Merged

moq-bot[bot] merged 2 commits into
mainfrom
quest/m2/speed/ed25519-verify-bench

Conversation

@kixelated

@kixelated kixelated commented Nov 7, 2026 •

Copy link
Copy Markdown
Collaborator

Plans quest/m2/speed/ed25519-verify-bench.md [XS], a follow-up from moq-dev/rind#415.

The ed25519-verify bench rows aren't comparable. rind's row parses the public key inside the timed loop, about 4 µs per verify, while the aws-lc-rs and dalek rows parse it once outside. Every host's report therefore overcharges rind. With the key parsed once, rind was level with dalek or faster (25-27 µs against 29-30, on an i7-8700 with ADX off).

The maintainer decided on 2026-11-07 to plan it in m2 speed.

Checks

  • quest check passes.

(Written by Claude Opus 5.5)

🤖 Generated with Claude Code

Review

mechanical fix by quest land watch: merged main at 9cd54e99b0c16d77365422d5d7ffddd7db3517ef with the quest merge driver (head efaad70)

…ry the same way

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@pullfrog

pullfrog Bot commented Nov 7, 2026 •

Copy link
Copy Markdown

Your OpenCode Go account is out of credit. Top it up, then re-trigger Pullfrog.

OpenCode Go's response
provider error: Insufficient account funds

Top up OpenCode Go →

Pullfrog  | Rerun failed job ➔ | View workflow run | via Pullfrog | Using glm-5.3

@kixelated
kixelated enabled auto-merge November 7, 2026 00:38
@coderabbitai

coderabbitai Bot commented Nov 7, 2026 •

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 63c336cf-ba82-4196-8162-eb8947077e5e
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@kixelated
kixelated added this pull request to the merge queue Nov 7, 2026

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed head 212265427b175b8a825a6702627b878ade2d918e.

No actionable findings in this planning change. The stated key-setup asymmetry matches the benchmark: rind/graviola parse inside the loop, while aws-lc-rs/dalek do so outside. The all-library goal is sound.

Implementation direction: include OpenSSL's reusable key setup and clearly label APIs that take raw key bytes. Refresh the OVH host measurements before removing their gap entries: nightly imports CPU-tier results, while host data needs a separate collection and render --from.

Verification: GitHub-only review of both changed documents, benchmark rows and report import/render paths. No benchmark implementation or results change here. I did not run quest validation or benchmarks, and the quoted performance numbers were not independently reproduced. Queue checks are skipped.

(Written by review, OpenAI)

@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Nov 7, 2026
@moq-bot

moq-bot Bot commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

quest land watch: the merge queue removed this pull request at 2122654 because it conflicts with main (merge_conflict).

The land fixer works on it in the background, and the watcher re-enqueues it at the back of the queue once it is fixed or judged flaky, or hands it back here with what it needs.

(written by quest land watch)

@moq-bot
moq-bot Bot added this pull request to the merge queue Nov 7, 2026
@moq-bot

moq-bot Bot commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

quest land watch: re-enqueued this pull request at efaad70, at the back of the merge queue, with main at 9cd54e9 merged in by the quest merge driver.

(written by quest land watch)

Merged via the queue into main with commit 1d28573 Nov 7, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant