Repository navigation
chore(quest): quinn's provider-neutral PR waits on quinn-rs/quinn#2701 - #469
Merged
Merged
Conversation
Quest-Claim: 8d93f6378c67d9ec
The ring patch already runs quinn 0.11 on rind in a binary, but only the upstream change lets libraries on quinn offer rind-rustls from crates.io. quinn's maintainers want it on main after the rustls 0.24 move, so the quest now waits on that PR and records what is left to call the provider. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kixelated
marked this pull request as ready for review
November 7, 2026 07:26
|
Your OpenCode Go account is out of credit. Top it up, then re-trigger Pullfrog. OpenCode Go's response
|
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 44 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Claims quest/m2/adoption/quinn.md and rewrites it to what remains: the upstream change can't start until quinn-rs/quinn#2701 lands, so the quest now records the upstream state and waits on that PR.
Verdict: still worth it, though no longer urgent
The ring patch from moq-dev/rind#444 and moq-dev/rind#456 already runs quinn 0.11 on rind, but it has limits:
[patch].Only the upstream change fixes that last point. quinn's maintainers already want it on main: drop the provider features in favor of an explicit provider (djc and Ralith on quinn-rs/quinn#2671). That makes acceptance likely, and it means quinn may do the work itself.
Upstream state (2026-11-06)
crypto::rustlsmodule only compiles withrustls-ringorrustls-aws-lc-rs.rustls-no-provider) was closed. djc pointed main at the route above and refused any RustCrypto dependency.PacketKey, which is ctz's first WIP commit. rustls 0.24 itself is unreleased (0.24.0-dev.2).quinn-proto/src/crypto/ring_like.rs)default_provider()callsAeadKey::with_lengthis crate-private).Upstream post (maintainer decision)
quinn's AI policy welcomes AI-written code but requires the PR body and comments to be in the contributor's own words. So there is no drafted text here, only facts for a comment on quinn-rs/quinn#2341:
Arc<CryptoProvider>replacesrustls-ringandrustls-aws-lc-rshmac_sign(ctz's 34cc6531)AlgorithmThe quest's
## Waitingrecords this as aMaintainer:item, recommended.Choices made without asking
Requiredlink to the rustls 0.24 release quest. #2701 decides when quinn moves, and could merge on a 0.24 pre-release.Public API
None. This only changes a quest file.
Validation
quest check --base origin/mainandjust checkpassed.Follow-ups
Models
Size: M
Implementer: Claude Code, claude-opus-5-5, high effort
Review
Rewritten by
quest reviewafter each round.01a1b4e5-53c8-7503-aeb5-658aa06750a5, round 1The documentation-only change matches the verified upstream direction, introduces no executable paths, and passes git diff --check; no actionable defects were found.(Written by Claude Opus 5.5 with high)