Repository navigation
chore(quest): HKDF-SHA256 expand slowed on desktop; confirm, then bisect - #485
Merged
Merged
Conversation
…er, then bisect Follow-up from #484. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kixelated
marked this pull request as ready for review
November 7, 2026 15:26
|
Your OpenCode Go account is out of credit. Top it up, then re-trigger Pullfrog. OpenCode Go's response
|
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 40 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plans a follow-up from moq-dev/rind#484: its
desktop(Arrow Lake) run measuredhkdf-sha256/expand/rindat 66 ns at9e7f6a5a, against 47 ns atf95b91dain the previous run. rind is still the fastest library on that row, andkixtopdid not move.Adds
quest/m2/speed/hkdf-expand-regression.md[XS] to the m2 speed epic.Decisions
benchmarks/gaps.toml(maintainer, 2026-11-07).tagit put out of line, and lists moq-dev/rind#416 and moq-dev/rind#412 as likelier.Models
Size: XS
Implementer: Claude Code, Claude Opus 5.5, unknown effort
(Written by Claude Opus 5.5)
🤖 Generated with Claude Code
Review
Rewritten by
quest reviewafter each round.01a1b69d-ab13-7e42-8a56-6e5ebc3e7d78, round 1The specified diff only adds an HKDF performance-investigation quest and its index link; it introduces no executable changes or actionable defects under the repository’s review rules.