Repository navigation
Conversation
Quest-Claim: b093ec1d46d97a5e
Co-Authored-By: GPT-6.1 Sol <noreply@openai.com>
Co-Authored-By: GPT-6.1 Sol <noreply@openai.com>
…-lc-rs/aws-lc-rs-patch
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Renaming a direct dependency to rind-aws-lc-rs cannot move transitive aws-lc-rs users onto rind.
Approach
Exercise the unpublished aws-lc-rs shim from moq-dev/rind-patch#1 through s2n-quic-crypto and jsonwebtoken, alongside the existing ring QUIC handshake. Patch both rind adapters to this checkout and reject metadata containing registry copies or aws-lc-sys. Run the fixture when either adapter changes. Document binary workspace patches, version constraints, key wiping, and API gaps. Remove the completed quest and its epic.
Impact
Alternatives
Reuse the published adapter rather than duplicate crypto. Per-crate renames do not reach transitive dependencies.
Decisions
feat/aws-lc-rs-shimin the companion PR; no submodule pointer was changed.Validation
quest gate sh/patch.sh: passed formatting, clippy with denied warnings, metadata checks, and all three executable fixtures.cargo tree -i aws-lc-sys: no matching package, exit 101 as expected.quest gate just ci: passed the full gate, including 725 workspace tests (10 skipped by the existing configuration), 18 wipe tests, doc tests, MSRV and cross-backend checks, dependency policy, Python and Dart checks, fixtures, quest validation, shell and Nix lint.quest check --base origin/main: 150 documents valid.quest gate just check origin/mainpassed, running every check including the patch fixture.Follow-ups
None.
Waiting
revpin inpatch/fixture/Cargo.tomland the(\?rev=[0-9a-f]{40})?allowance insh/patch.sh, so the fixture tests the shim's main branch, rerunjust check, and run/quest-review. Check withgh pr view 1 -R moq-dev/rind-patch.Models
Size: S
Implementer: Codex, gpt-6.1-sol, xhigh effort
(Written by GPT-6.1 Sol with xhigh)
Review
Rewritten by
quest reviewafter each round.e0da6286-e864-4933-946c-b4dbf1d2e2ec, round 1The docs and fixture match the recorded plan, but the pinned shim revision means CI doesn't test the shim main branch that users are told to patch from.patch/fixture/Cargo.toml:28:aws-lc-rs shim pinned to a fixed rev with nothing forcing its removalsh/patch.sh:19:Comment claims generate-lockfile takes shim revisions afresh, but the pinned aws-lc-rs can'tMIGRATE.md:71:Stop condition omits hard-wired aws-lc-rs older than 1.xHead 90663a1, round 1 dispositions (all low, so no further round):
patch/fixture/Cargo.toml:28pin with nothing forcing its removal: fixed by gating. The## Waitingitem now requires dropping the pin before this PR leaves draft; it cannot be dropped earlier, since the shim is not on rind-patch's main yet.sh/patch.sh:19comment vs. pinned aws-lc-rs: same cause, resolved with item 1 when the pin and the?rev=allowance go. The comment is accurate meanwhile:generate-lockfilere-resolves each revision the fixture names.MIGRATE.md:71aws-lc-rs older than 1.x: refuted. The only pre-1.0 release on crates.io is 0.0.1, a 931-byte placeholder whose description reads "Please use aws-lc-sys", and 1.0.0-rc1 is matched by the patch's 1.999.0, so no hard-wirable older aws-lc-rs exists.(Written by Claude Opus 5.5)