Repository navigation
chore(quest): plan compiling wasm32 on every PR - #545
Conversation
wasm32 becomes a compile-only target of the targets epic, checked in `just check`'s cross module, after #543 restored the build. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 39 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
There was a problem hiding this comment.
ℹ️ Minor suggestions only — one stale-reference sweep missing.
Reviewed changes
- New
[S]questquest/m2/adoption/targets/wasm.md: move the wasm32 compile checks (wasm32-unknown-unknownwithgetrandom/wasm_js, andwasm32-wasip2, each with and withoutwipe) intojust check'scrossmodule, gain both targets in the flake's pinned toolchain, delete #543's nightlybuild.ymljob as redundant, and havePLATFORMS.mdsay PRs check it. - Targets epic (
quest/m2/adoption/targets/README.md) reverses the 2026-11-06 "minus wasm" decision with a dated replacement note in the Plan, rewords Goal/Non-goals for a compile-only wasm32, and links the new child in Required. - Cross-reference sync: the adoption epic's link line and the MoQ epic's "wasm32 does not build rind" line now match the new state.
Verified against the tree: the cross module and its scope regex exist in sh/dispatch.sh, check.yml runs it under the flake toolchain that already carries the other cross targets, #543's diff adds exactly the nightly job the quest deletes (its checks pass, so getrandom/wasm_js and both targets compile), and the #412/#512 MD5 black_box account matches #543's change. No code changes, so no mutants-pin or Sources-table shifts.
glm-5.3 ｜ 𝕏
|
|
||
| Every PR that changes rind's code compiles the `rind` library for `wasm32-unknown-unknown` (with `getrandom/wasm_js`) and `wasm32-wasip2`, with and without `wipe`, in `just check`'s `cross` module, so a wasm build break fails before merging rather than in a nightly run. | ||
| The flake's pinned toolchain gains both targets. | ||
| The nightly `wasm` job in `build.yml` that [moq-dev/rind#543](https://github.com/moq-dev/rind/pull/543) added is deleted as redundant, and [PLATFORMS.md](/PLATFORMS.md) says PRs check it. |
There was a problem hiding this comment.
This reversal leaves three docs still stating the pre-#543 "no wasm build" state, and the quest's deliverables only name PLATFORMS.md. quest/m0/adapters/ring.md:14 is the one that matters most — it records the old state unqualified in the quest tree. Add these to the quest's Goal (or repoint them here), so the reversal is recorded both ways.
Technical details
# wasm reversal leaves stale "no wasm build" claims
## Affected sites
- quest/m0/adapters/ring.md:14 — "`wasm32_unknown_unknown_js` stays a no-op because rind doesn't build for wasm32 at all". The reason goes stale once #543 lands; the conclusion (no browser build loses entropy) still holds, since the adapters stay non-goals on wasm, but the cited state is the one this epic reverses. Convention: a call reversal adds pointers both ways (as the m4 parity epic did for its out-of-reach call).
- MIGRATE.md:56 — "rind compiles only for x86_64, aarch64, and 32-bit ARM, so i686, wasm32, riscv64, and every other architecture fail to build".
- rind-dart/pubspec.yaml:15 — "# No web: rind has no wasm build, so the package refuses that target." The refusal itself can stay (the build hook is native-only); only the stated reason goes stale.
## Required outcome
- Each site either states the new state (the rind library compiles for wasm32, compile-checked on every PR) or links the quest / targets epic as the record of the change.
Plans quest/m2/adoption/targets/wasm.md, a follow-up of moq-dev/rind#543, which restored the wasm32 build and added a nightly compile job. The new quest makes
just check'scrossmodule compile the rind library for wasm32 on every PR, so a break like moq-dev/rind#412's fails before merging.Changes
[S]questquest/m2/adoption/targets/wasm.md, a child of the targets epic.Decisions
Settled with the maintainer on 2026-11-09:
wasm32-unknown-unknownandwasm32-wasip2, with and withoutwipe, replacing fix(md5): restore WebAssembly builds #543's nightly job (rejected: also compile rind-rustls; keep the nightly job too).Public API
None. Quest files only.
Checks
quest checkandjust checkpass.Models
Size: XS
Implementer: Claude Code, claude-opus-5-5, high effort
(Written by Claude Opus 5.5 with high)
Review
Rewritten by
quest reviewafter each round.01a1c2c4-f102-7190-9530-8faa1e199514, round 1The documentation-only change updates planning documents and adds the wasm32 compile-check quest, with no executable code changes or actionable defects.