Repository navigation
Conversation
This reverts commit 8b2dd4c.
release-plz proposed rind-rustls 0.24.0 and rind-rcgen 0.15.0, which the adapter version rule refuses: an adapter's version begins with its upstream's breaking part. Both changes restore upstream's API, so each is a patch release. Co-Authored-By: Claude <noreply@anthropic.com>
This reverts commit c124961.
… by hand main holds two breaking rind changes at a hand-set 0.3.3, which the release PR would publish as a patch. Setting 0.4.0 makes them, and any later one, publish under the right version. The adapters require rind 0.4.0 and keep their upstream's version prefix. Co-Authored-By: Claude <noreply@anthropic.com>
This was referenced Nov 10, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sets
rindto 0.4.0 and four adapters to their next patch versions by hand, so the pending release publishes whatmainholds under the right versions.Why
mainholds two breaking changes torind: the typedCbcIv(moq-dev/rind#530) and agreement keys that keep their public key (moq-dev/rind#529). Both merged whilerind/Cargo.tomlwas hand-set to 0.3.3 and unpublished. A hand-set version is kept as is, so release PR moq-dev/rind#511 proposedrind0.3.2 to 0.3.3 with both breaks inside it, and nothing in CI refuses that.#511 also proposed
rind-rustls0.24.0,rind-rcgen0.15.0,rind-ring0.18.0, andrind-str0m0.26.0. An adapter's version begins with its upstream's breaking part, andsh/adapter-versions.shrefuses all four in the merge queue. That check was the only thing keeping #511 from publishing the breaks as a patch.Changes
rind0.3.3 to 0.4.0, and every workspace crate'srindrequirement to 0.4.0.rind-rustls0.23.4 andrind-rcgen0.14.4: each restored its upstream's API, which CONTRIBUTING.md makes a patch release set by hand.rind-ring0.17.4 andrind-str0m0.25.3: their own APIs did not change. feat(agreement)!: keys keep their public key and algorithm #529 and fix(rcgen)!: KeyPair offers rcgen's KeyPair API #515 touched their internals, and a!title makes release-plz propose the next breaking version for every crate its commit touches.The branch first reverted #530, as first decided, and then undid that revert when the decision changed; its net diff is manifests,
Cargo.lock, and the README.Decisions
Decided with the maintainer on 2026-11-09, in the quest audit (moq-dev/rind#546):
main: revert it and release 0.3.3 now.!change merged before 0.3.3 published; a hand-set 0.4.0 ends it.After this merges
rind0.4.0 and each adapter at a patch version; check before merging it.mainand MoQ's PR (moq-dev/moq#8400 plans it) is ready. Until then no adapter fix and no pyrind release publishes.!on adapters; if release-plz proposes a breaking version for one after they merge, it needs the same hand-set patch.Public API and wire
No API change beyond what #530 and #529 already merged. This changes the version they publish under:
rind0.4.0, where a consumer onrind = "0.3"is not moved onto them. Each adapter now requires rind 0.4.0. Wire: none.Caused by
rindchange while its hand-set 0.3.3 was unpublished!and no hand-set patch versionChecks
sh/adapter-versions.shpasses andcargo metadata --lockedresolves.just checkis queued behind a host-wide job on this machine; this stays a draft until it passes.Models
Size: S
Implementer: Claude Code, claude-fable-5-2, high effort
🤖 Generated with Claude Code
(Written by Claude Fable 5 with high effort)