Repository navigation
Conversation
Quest-Claim: 34726cb0d0885089
…q-net Since #668 the exporter refuses a whole-crate `pub use`, and the stand-in's config did not exclude `hang::moq_net` or `tokio::moq_net`, so `just ffi moq` failed at the pinned moq revision. Both are excluded; nothing new exports. Caused by: [#668](#668) - refused whole-crate re-exports the stand-in's config did not exclude. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
…y items Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
# Conflicts: # quest/m1/ffi-export/refusals/moq-pin.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Claims quest/m1/ffi-export/refusals/moq-pin.md.
This head merges
main, leaves out the two whole-crate re-exports the stand-in still exported, and narrows the quest. The pin bump is not on this head: moq'smainfailsjust ts moqandjust ffi moq-cpp, see Waiting.Decisions
bad28cefwhen the maintainer decided, and it has moved to10772522a. I bumped to10772522aand measured it. Bothbad28cefand10772522afail the merge gate, so the bump is held (a local checkpoint, not pushed) and this head keeps the pin atffcb7cd9.just ffi moqalready fails on main at the pin. feat(ffi)!: refuse a whole-crate re-export with one span #668 refuses whole-crate re-exports, and the stand-in config does not excludehang::moq_netortokio::moq_net. This head adds those two excludes. No C item changes: both were refused, so nothing new exports.m2/api-shape/reexports.md,m2/moq-quic-unused-surface.md) are gone from moq'smain, so their items are removed.22485b345with the quest audit, which also editedmoq-pin.md. I merged it. The conflict kept the audit's[S]title, its facts on moq's merged fixes, and itsjust ts censusnote for a bump. It replaced the audit's Waiting maintainer item with the hold above, and kept the narrowed Goal.Census
just ffi census(the stand-in, frommoq/ffi.toml), with main's exporter at both revisions. The "items" column is the census's own construct table.ffcb7cd9(pin)10772522a(held bump)At
ffcb7cd9, the 18 are Guard (16) andmoq_quic::Side(2). At10772522a, the 9 arekio::Pending(2, fromdial_tcpanddial_track),lite::version::Version(1), and moq-quic's stats and varint types under moq-tokio'squic::driver(6), which narrow-standin drops.Impact
Caused by
hang's and moq-tokio'spub use moq_net;, sojust ffi moqfailed on main.Waiting
ffcb7cd9, and land this head once the maintainer agrees. Un-hold by bumping oncejust ts moq <checkout>andjust ffi moq-cpp <checkout>pass at moq'smain. Options: (a) hold, recommended; (b) bump to10772522aanyway, which can't land because the merge gate fails atjust ts moq; (c) another moq revision, none of which I have found passing both checks.rindbuilds for wasm32. moq-net depends onrind, whose md5 inline asm has no wasm32 arm, sojust ts moq <checkout>fails at moq'smain. Done when it passes there. Arind0.3.2 probe got past that error and then hit getrandom'swasm_jsfeature, so it is not a drop-in fix.recursion_depth_exceeding_limit, whichjust ffi moq-cpp <checkout>denies. It passes atffcb7cd9and fails atbad28cefandmain. Done when it passes at moq'smain.kio::Pendingandlite::version::Versionare reachable from moq-net's root. Done whenjust ffi census <checkout>lists no "type not reachable from the crate root" for them.quest/m1/ffi-export/refusalsis checked out in another worktree and blocksquest startin this checkout, so this session pushed by refspec fromiterate/moq-hold. Check withgit branch --list 'quest/m1/ffi-export/refusals', which should print nothing once it is renamed or deleted.Models
Size: XS
Implementer: Claude Code, claude-haiku-5-5, high effort (iterate, XS)
(Written by Haiku 5.5 with high)