Repository navigation
docs(quest): plan web and WASI as separate wasm targets - #685
Merged
Merged
Conversation
The web target calls web APIs directly, performance.now for its clock, and ships nothing of WASI. A WASI target for hosts with no JavaScript is its own m3 quest. Co-Authored-By: Claude <noreply@anthropic.com>
kixelated
marked this pull request as ready for review
November 10, 2026 01:16
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 4 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
#684 left rust2-wasm's clock open and recommended one
wasm32-wasip1module whose imports the binding satisfies. The maintainer decided otherwise: web and WASI are separate targets, and the web's uses web APIs where one exists,performance.nowfor its clock.Approach
Quest files only.
quest/m2/wasm/backend.mdis now the web target: its clock, randomness, and stderr are web APIs called directly, with nothing of WASI in the bundle. What stays open is only how a stock crate'sstd::timereachesperformance.now, since std forwasm32-unknown-unknownhas no clock and no hook for one.quest/m3/wasi.md: a report on a WASI target for hosts with no JavaScript, as a core module over the C ABI or as a component with generated WIT.Decisions
wasm32-wasip1module for both).Choice made without asking, for review: the web target's recommended mechanism is still to compile against
wasm32-wasip1's std and bind each import the module declares to its web API in the generated binding, with the import names an internal detail and no WASI runtime shipped. The alternatives listed are a source change in the crate, a patched std, or a web std of rustc's own if one exists.Impact
Alternatives
Follow-ups
None.
Models
Size: S
Implementer: Claude Code, claude-fable-5-2, high effort
🤖 Generated with Claude Code
(Written by Claude Fable 5 with high)
Review
Rewritten by
quest reviewafter each round.01a1c306-97bd-78d1-ac3a-068406d4030b, round 1The diff changes planning documents only, with a coherent web/WASI split and implementation choices explicitly left for investigation; no actionable defects were found.