Skip to content

fix(scene): retire the replaced rendition cleanly in a flaky replacement-delay test #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kixelated merged 2 commits into from
Nov 5, 2026
Merged

fix(scene): retire the replaced rendition cleanly in a flaky replacement-delay test #51

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ebc3484
fix(scene): retire the replaced rendition cleanly in a_replacement_tr…
kixelated Nov 5, 2026
8ecfd98
Merge remote-tracking branch 'origin/main' into HEAD
kixelated Nov 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion rs/moq-scene/src/source.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2318,7 +2318,12 @@ mod tests {
)
.unwrap();
let (video, mut encoder) = rendition(&live.broadcast, timebase).await;
drop(std::mem::replace(&mut live.video, video));
// Finished before it goes, as a publisher retires a rendition: one
// dropped unfinished aborts its track, which fails the source if
// that reaches it before the catalog naming the replacement does.
let mut old = std::mem::replace(&mut live.video, video);
old.finish().unwrap();
drop(old);
until_time(kio::clock::now()).await;
let arrived = kio::clock::now();
picture(&mut live.video, &mut encoder, 0);
Expand Down