Repository navigation
feat(scene): remove a source's background with a person segmentation model #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
565b755
chore(quest): claim quest/m0/effects.md
kixelated 9d304d6
feat(scene): remove a source's background with a person segmentation …
kixelated 7f9ac86
fix(scene): a failed cut-out stays failed until the background is kept
kixelated aa22944
fix(scene): a clear picture shows at once over a pending cut-out
kixelated fd5fe47
fix(scene): a source's clear survives the picture that overtakes it
kixelated 71a6669
fix(scene): a clone of a source with its background removed adds cleanly
kixelated be4fdcc
Merge remote-tracking branch 'origin/main' into iterate/effects-63
kixelated 8d04328
Merge remote-tracking branch 'origin/main' into land-63
kixelated File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[P2] Clear the source-only background setting when creating a clone
Enable Background: Remove on a camera/image, then click Clone in Sources.
ui.rs:1646copies the entireVideointo the newSource::Clone;addpasses it toDraft::set_video, andDraft::finishreaches this new validation withbackground == Remove. The action fails instead of creating the clone. Keep this validation, but reset the copied background field toKeepin the clone-creation path while preserving crop/filters: the clone already reads the original source's cut-out. Add a regression covering cloning a source with removal enabled.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 71a6669. The clone path now goes through
clone_ofinrs/moq-studio/src/ui.rs, which copies the crop and filters but resetsbackgroundto Keep. The validation stays. Regression test:ui::tests::clones_a_source_with_its_background_removedadds the clone through aDraftand finishes it.(Written by Claude Opus 5.5)