Repository navigation
2026 11 09 tjr bugzilla retry commandeered - #460
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Gateway errors during verification can bypass remaining retries, and closure checks can falsely report success without updating the duplicate target or posting the required comment.
2 open issues
What changed in this PR
This PR improves Updatebot’s handling of transient Bugzilla failures and Phabricator revisions taken over by another author.
Changes:
- Adds bounded retries for Bugzilla gateway errors, with checks intended to avoid repeating completed writes.
- Treats inability to abandon another author’s Phabricator revision as nonfatal.
- Adds regression tests for retry behavior and commandeered revisions.
| File | Description |
|---|---|
tests/functionality_all_platforms.py |
Tests build-failure handling when a revision has been commandeered. |
tests/bugzilla.py |
Adds gateway-error simulations and retry regression tests. |
apis/phabricator.py |
Logs and tolerates abandonment failures caused by changed ownership. |
apis/bugzilla_api.py |
Adds gateway-error classification, write retries, and completion checks. |
Review effort: Balanced
tomrittervg
force-pushed
the
2026-11-09-tjr-bugzilla-retry-commandeered
branch
from
November 10, 2026 12:25
2bd1a10 to
f371476
Compare
#397 Phabricator won't let us abandon a revision we're no longer the author of. That error was retried and then reported on the bug as a failure to abandon it; now we log it and move on, since the revision is the new author's to keep or abandon.
…ng them. Fixes #401 Bugzilla's front end sometimes fails a request with a 502, 503 or 504 (e.g. '504 stream timeout'). Retry filing bugs, commenting and closing bugs when that happens, but first check whether the failed attempt went through anyway, so we don't file or comment twice: a run's bugs and comments are marked with its task id. (The response's status code is already in the error, since _load_json_or_raise.)
tomrittervg
force-pushed
the
2026-11-09-tjr-bugzilla-retry-commandeered
branch
from
November 10, 2026 13:44
f371476 to
3d1e43b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.