Repository navigation
2026 11 09 tjr authors reviewers - #461
Merged
Merged
Conversation
…ixes #419 Setting the reviewer with reviewers.set removed anyone who was already reviewing the revision, such as someone added while the try run was going.
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Valid ISO-8859-1 commits with non-ASCII text can trigger UTF-8 decoding errors in the command runner and SCM provider, causing vendoring bug reports to omit upstream commit details.
1 open issue
What changed in this PR
This PR adds author and signature-presence summaries to vendoring bug reports and preserves existing Phabricator reviewers when adding a reviewer.
Changes:
- Detect commit signatures without verifying them and summarize commit counts by author.
- Include author summaries in Bugzilla descriptions and account for their length.
- Switch Phabricator reviewer updates from replacement to addition, with updated tests and fixtures.
| File | Description |
|---|---|
tests/functionality_utilities.py |
Updates reviewer mocks and adds a signed-commit fixture. |
tests/build_bug_description.py |
Tests signature detection, author summaries, and summary placement. |
tasktypes/vendoring.py |
Includes author summaries and adjusts the commit-detail length budget. |
components/scmprovider.py |
Detects signature headers and builds per-author summaries. |
components/bugzilla.py |
Adds optional author summaries to update comments. |
apis/phabricator.py |
Adds reviewers without removing existing reviewers. |
Review effort: Balanced
… bug description. Fixes #362 After the diff statistics, list each author's number of commits, most first, and whether their commits were signed (with GPG or SSH). Updatebot can't verify the signatures without the signers' keys, only tell whether there is one.
tomrittervg
force-pushed
the
2026-11-09-tjr-authors-reviewers
branch
from
November 10, 2026 12:25
c92c2e2 to
79a30e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.