Repository navigation
2026 11 10 tjr commandeered task - #462
Merged
Merged
Conversation
Every Phabricator Conduit call built its own echo | arc call-conduit command and repeated the JSON decoding and error handling. Do that in _call_conduit, with _search_one and _edit_revision for the common cases, and a ConduitError that keeps Phabricator's error message for abandon to check.
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The test fails when TASK_ID is already set, and nested retries in ownership checks can trigger 100 identity requests and stall vendoring for over 93 minutes.
2 open issues
What changed in this PR
This PR updates vendoring job cleanup to preserve bugs and revisions taken over by another author, and records the Taskcluster task that created each job.
Changes:
- Detect commandeered revisions and leave their bugs open when newer updates supersede them.
- Consolidate Phabricator Conduit calls into shared helpers.
- Add job task IDs, a database migration, and regression coverage.
| File | Description |
|---|---|
tests/functionality_utilities.py |
Update Conduit mocks and add identity responses. |
tests/functionality_all_platforms.py |
Cover superseding a job with a commandeered revision. |
tests/database.py |
Test task ID persistence, absence, and migration. |
tasktypes/vendoring.py |
Preserve commandeered revisions and their open bugs. |
components/dbmodels.py |
Expose task IDs on job objects. |
components/db.py |
Add schema version 17 and store job task IDs. |
components/bugzilla.py |
Add a comment explaining why a superseded bug remains open. |
apis/phabricator.py |
Refactor Conduit helpers and detect revision ownership changes. |
Review effort: Balanced
…ixes #384 When a newer version of a library comes in, Updatebot closes the previous bug as a duplicate of the new one and abandons its revisions. If someone has taken over one of those revisions, they're working on it, so leave the bug open and say why.
Add a task_id column to the jobs table (database version 17), so a job can be traced back to the Updatebot run that created it, even if it never got a bug.
tomrittervg
force-pushed
the
2026-11-10-tjr-commandeered-task-id
branch
from
November 10, 2026 20:16
b7726b3 to
d93c0ee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.