Repository navigation
2026 11 12 tjr issue fixes - #464
Merged
Merged
Conversation
If an update changes moz.yaml's license-file, or a file under the vendor directory named like a license (LICENSE*, COPYING*, NOTICE*, ...), the bug description starts by listing them and asking for the license in moz.yaml to be checked. This happened in 3 of Updatebot's 439 commits in the past year, so it should rarely fire. It's a note rather than a failure: stopping the update would only leave us on older code.
Every method a mock defines must exist on the real class with the same signature, so a change to a provider's interface can't leave tests passing against the old one.
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are recorded for the command-output handling, vendoring diagnostics, and license-change notification updates.
No open issues 🎉
What changed in this PR
This PR improves Updatebot’s command-output handling and vendoring diagnostics, while adding license-change notices to update bugs.
Changes:
- Standardizes command output as UTF-8 text with replacement for invalid bytes, updating callers and mocks.
- Detects changed license files and adds a review reminder to Bugzilla descriptions.
- Logs repository status when try submissions reject uncommitted changes, and adds regression and mock-interface tests.
| File | Description |
|---|---|
tests/treeherder_api.py |
Tests uncommitted-change diagnostics for failed try submissions. |
tests/scm.py |
Uses text stderr in the checkout-failure mock. |
tests/run_command.py |
Tests text output, invalid UTF-8 handling, and timeouts. |
tests/mock_interfaces.py |
Checks mock method signatures against real providers. |
tests/mock_commandprovider.py |
Returns text stdout and stderr from command mocks. |
tests/mach_vendor.py |
Updates patch-failure tests to expect text output. |
tests/license_files.py |
Tests license-file detection and notification text. |
tests/library.py |
Tests parsing of license-file metadata. |
tests/build_bug_description.py |
Uses text output in commit-detail mocks. |
tests/aiprovider.py |
Returns text stdout from the AI command mock. |
test.py |
Registers the license-file and mock-interface test suites. |
tasktypes/vendoring.py |
Detects license changes, prepends notices, and consumes text errors. |
components/scmprovider.py |
Consumes Git command output directly as text. |
components/mach_vendor.py |
Handles vendoring output and errors as text. |
components/logging.py |
Reads version and hostname output as text. |
components/libraryprovider.py |
Stores license-file metadata and consumes text command output. |
components/hg.py |
Adds directory-scoped change queries and consumes text output. |
components/commandrunner.py |
Decodes subprocess output centrally and handles timeout output for logging. |
components/commandprovider.py |
Processes traceback stderr as text. |
components/bugzilla.py |
Adds a license-change reminder template. |
components/aiprovider.py |
Parses AI command output without explicit decoding. |
automation.py |
Reads the Updatebot version from text output. |
apis/taskcluster.py |
Logs dirty-checkout status on try rejection and consumes text output. |
apis/phabricator.py |
Parses Conduit and submission responses as text. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.