Bug 2065864 - Match webhook event selections exactly - #2724
Merged
dklawren merged 2 commits intoAug 25, 2026
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Fixes webhook routing by matching stored event selections as exact tokens.
Changes:
- Parses comma-separated webhook events into an exact lookup map.
- Prevents
attachment_changefrom matching unrelated events. - Adds regression coverage for individual, combined, and product-move routing.
Show a summary per file
| File | Description |
|---|---|
extensions/Push/lib/Connector/Webhook.pm |
Uses exact event-token matching. |
extensions/Push/t/webhook.t |
Adds webhook routing regression tests. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Balanced
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug 1979028 added the
attachment_changewebhook event, butshould_sendchecked the comma-separated event setting with substring regular expressions. Becauseattachment_changecontains bothchangeandattachment, a webhook configured only for attachment modifications also received bug modification and new attachment events.This parses the stored setting into exact event tokens before applying the existing routing-key checks. It also uses the exact
changetoken for the moved-product/component fallback, where the same substring collision occurred.The new connector test covers each event independently, verifies that
attachment_changedoes not leak into the two shorter event names, and exercises combined selections and the moved-product path.Bug: https://bugzilla.mozilla.org/show_bug.cgi?id=2065864
Testing:
test_sanity t/001compile.t t/002goodperl.t t/005whitespace.t extensions/Push/t/webhook.t