Repository navigation
Post-deploy housekeeping: build order, source maps, ogimage.xcf - #493
Merged
Merged
Conversation
npm-run-all build:* ran the scripts alphabetically, so build:app ran before build:css and only worked because CI and deploy compiled Stylus in a separate step first. Run them in order with run-s and drop those steps.
The production build emitted them for source-map-explorer, so about 3 MB of .map files were uploaded to the public bucket on every deploy. npm run size now builds with --sourcemap itself.
It sat in public/, so it was copied into build/ and deployed. Only the rendered PNG is used.
stevejalim
approved these changes
Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three of the four items from #488:
npm run buildnow runsbuild:css,build:appandbuild:version.jsonin order withrun-s. Before,npm-run-all build:*ran them alphabetically, so the Vite build ran before the Stylus compile it depends on. The separate "Compile Stylus" steps indeploy.ymland CI's lint-and-test job are gone; in CI, Build now runs before the unit tests because they import the compiled CSS. The Playwright jobs keep their Stylus step since they never run the build..mapfiles stop going to the public bucket on every deploy.npm run sizebuilds with--sourcemapitself before running source-map-explorer.public/img/ogimage.xcf(the GIMP source forogimage.png) is deleted so it is no longer copied intobuild/and deployed.The fourth item, removing the old create-react-app
static/tree from the prod bucket, is a manual step after a prod deploy and stays open on the issue.Refs #488, WT-1916.