Repository navigation
Keep heading levels in order (fix #181) - #501
Merged
Merged
Conversation
Collaborator
Author
|
Approved as #475 but then its merge when sideways. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One-line summary
Fix the heading levels that skip on
/contactand on dashboards that have no Summary section.Significant changes and points to review
Contact.jsx: add a visible "Contact"h2. Before this, the page went from the siteh1straight to the footer'sh3s.Dashboard.styl: hide the "Metrics"h3visually instead of withdisplay: none. Screen readers skipped it, so on User Activity and Usage Behavior the metrich4s followed theh2directly.h3comes first.contact.spec.js: check the new heading.heading-ordercheck now passes on/,/contact, all three dashboards, and the 404 page.Issue / Bugzilla link
#181
Testing
Run
npm startfirst.http://localhost:3000/contactand check a "Contact" heading appears above the email paragraph.http://localhost:3000/dashboard/user-activityand check the layout hasn't changed. "Metrics" should not be visible.