Skip to content

fix: use integration domain for reporting endpoints#105

Merged
khushi1033 merged 1 commit into
developmentfrom
fix/no-jira-reporting-integration-domain
Jul 1, 2026
Merged

fix: use integration domain for reporting endpoints#105
khushi1033 merged 1 commit into
developmentfrom
fix/no-jira-reporting-integration-domain

Conversation

@mattbodle

Copy link
Copy Markdown
Collaborator

Summary

  • Updates the logging and error reporting services so their default endpoints are derived from the integration domain used to load the Rokt SDK assets.
  • Keeps explicit loggingUrl and errorUrl kit settings as overrides.
  • Preserves the apps.rokt-api.com fallback when no integration domain is configured.
  • Adds regression coverage verifying that mParticle.Rokt.domain = 'rkt.carrot.com' sends to https://rkt.carrot.com/v1/log and https://rkt.carrot.com/v1/errors.

Testing Plan

  • npm run lint
  • npm run test
  • npm run build completed with exit code 0; Vite still emits existing vite-plugin-dts diagnostics around mParticle identity types on untouched lines.

@mattbodle

Copy link
Copy Markdown
Collaborator Author

Verified the regression against the previous code path.

I created an isolated copy of origin/main, copied in only the new regression test, and ran:

npx vitest run -t "should default registered reporting services to the integration domain"

Result on old code: FAIL. The old implementation received:

https://apps.rokt-api.com/v1/log
https://apps.rokt-api.com/v1/errors

when the test expected:

https://rkt.carrot.com/v1/log
https://rkt.carrot.com/v1/errors

Running the same focused test on this PR branch passes.

@khushi1033
khushi1033 changed the base branch from main to development July 1, 2026 15:19
@khushi1033
khushi1033 merged commit c3ec2e9 into development Jul 1, 2026
4 of 5 checks passed
github-actions Bot pushed a commit that referenced this pull request Jul 1, 2026
## [1.28.3](v1.28.2...v1.28.3) (2026-07-01)

### Bug Fixes

* use integration domain for reporting endpoints ([#105](#105)) ([c3ec2e9](c3ec2e9))
@mparticle-automation

Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 1.28.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants