fix: use integration domain for reporting endpoints#105
Merged
Conversation
Collaborator
Author
|
Verified the regression against the previous code path. I created an isolated copy of npx vitest run -t "should default registered reporting services to the integration domain"Result on old code: FAIL. The old implementation received: when the test expected: Running the same focused test on this PR branch passes. |
crisryantan
approved these changes
Jul 1, 2026
alexs-mparticle
approved these changes
Jul 1, 2026
github-actions Bot
pushed a commit
that referenced
this pull request
Jul 1, 2026
## [1.28.3](v1.28.2...v1.28.3) (2026-07-01) ### Bug Fixes * use integration domain for reporting endpoints ([#105](#105)) ([c3ec2e9](c3ec2e9))
Collaborator
|
🎉 This PR is included in version 1.28.3 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
loggingUrlanderrorUrlkit settings as overrides.apps.rokt-api.comfallback when no integration domain is configured.mParticle.Rokt.domain = 'rkt.carrot.com'sends tohttps://rkt.carrot.com/v1/logandhttps://rkt.carrot.com/v1/errors.Testing Plan
npm run lintnpm run testnpm run buildcompleted with exit code 0; Vite still emits existingvite-plugin-dtsdiagnostics around mParticle identity types on untouched lines.