Skip to content

ci: run the full and revdepcheck waves outside pull requests - #207

Merged
ms609 merged 1 commit into
mainfrom
ci/run-backstop-waves-on-push
Sep 21, 2026
Merged

ms609 merged 1 commit into
mainfrom
ci/run-backstop-waves-on-push

Conversation

@ms609-agent

Copy link
Copy Markdown
Collaborator

Follow-up to #206. On the merge commit 4ef39fc, core passed, but the full (ubuntu release, macOS x2) and revdepcheck waves were skipped.

Both jobs had needs: core and no if:, so each took the implicit success(). That condition is false whenever any upstream job was skipped, even indirectly. codemeta runs only on pull_request, so on push, schedule and workflow_dispatch both waves never ran. PR runs are unaffected, which is why #206's own checks didn't catch it.

The fix gates each job on !cancelled() && needs.core.result == 'success', matching how core gates on sense-check.

Validation is a workflow_dispatch run on this branch, where codemeta is also skipped. full and revdepcheck should run there after core.

Coreset's R-CMD-check.yml has the same structure, and so the same bug.

🤖 Generated with Claude Code

Both jobs had `needs: core` and no `if:`, so they took the implicit
success(), which is false whenever any job upstream was skipped, even
transitively. codemeta runs only on pull_request, so on push to main,
the weekly schedule and workflow_dispatch the macOS / ubuntu-release
backstop and every revdepcheck leg were skipped, though core passed.
First seen on the #206 merge commit (4ef39fc).

Gate on core's result explicitly, as core itself does on sense-check.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@ms609-agent
ms609-agent requested a review from ms609 September 21, 2026 10:34
@github-actions

Copy link
Copy Markdown

Performance benchmark results

Call Status Change Time (ms)
ClusteringInfoDistance(tr200) ⚪ NSD 1.71% 15.1, 15.2 →
14.9, 14.9
ClusteringInfoDistance(tr50) ⚪ NSD 0.16% 11.5, 11.6 →
11.6, 11.4
LAPJV(test2000) 🟣 ~same 2.55% 91.6, 91.1 →
89, 89.1
LAPJV(test40) ⚪ NSD -1.31% 0.0176, 0.0178 →
0.018, 0.0178
LAPJV(test400) ⚪ NSD 0.18% 3.18, 3.2 →
3.18, 3.18
MutualClusteringInfo(tr200) ⚪ NSD -1.92% 20.9, 21.4 →
21.2, 22
MutualClusteringInfo(tr50) ⚪ NSD 0.25% 21.9, 22.3 →
21.4, 22.4
PathDist(postTrees) ⚪ NSD 0.4% 3.33, 3.38 →
3.36, 3.32
PhylogeneticInfoDistance(tr200) ⚪ NSD 0.2% 230, 229 →
229, 229
PhylogeneticInfoDistance(tr50) ⚪ NSD 0.53% 80.6, 81.6 →
80.5, 81
RobinsonFoulds(tr200) ⚪ NSD -1.09% 2.87, 2.93 →
2.87, 3.04
RobinsonFoulds(tr200) ⚪ NSD 0.85% 2.73, 2.76 →
2.72, 2.73
RobinsonFoulds(tr50) ⚪ NSD 0.49% 4.44, 4.56 →
4.46, 4.5

@codecov

codecov Bot commented Sep 21, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.55%. Comparing base (4ef39fc) to head (032cbed).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #207   +/-   ##
=======================================
  Coverage   95.55%   95.55%           
=======================================
  Files          56       56           
  Lines        5041     5041           
=======================================
  Hits         4817     4817           
  Misses        224      224           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ms609
ms609 merged commit 7e594c9 into main Sep 21, 2026
31 checks passed
@ms609
ms609 deleted the ci/run-backstop-waves-on-push branch September 21, 2026 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants