Repository navigation
ci: run the full and revdepcheck waves outside pull requests - #207
Merged
Merged
Conversation
Both jobs had `needs: core` and no `if:`, so they took the implicit success(), which is false whenever any job upstream was skipped, even transitively. codemeta runs only on pull_request, so on push to main, the weekly schedule and workflow_dispatch the macOS / ubuntu-release backstop and every revdepcheck leg were skipped, though core passed. First seen on the #206 merge commit (4ef39fc). Gate on core's result explicitly, as core itself does on sense-check. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Performance benchmark results
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #207 +/- ##
=======================================
Coverage 95.55% 95.55%
=======================================
Files 56 56
Lines 5041 5041
=======================================
Hits 4817 4817
Misses 224 224 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #206. On the merge commit 4ef39fc, core passed, but the full (ubuntu release, macOS x2) and revdepcheck waves were skipped.
Both jobs had
needs: coreand noif:, so each took the implicitsuccess(). That condition is false whenever any upstream job was skipped, even indirectly.codemetaruns only onpull_request, so on push, schedule andworkflow_dispatchboth waves never ran. PR runs are unaffected, which is why #206's own checks didn't catch it.The fix gates each job on
!cancelled() && needs.core.result == 'success', matching howcoregates onsense-check.Validation is a
workflow_dispatchrun on this branch, where codemeta is also skipped.fullandrevdepcheckshould run there after core.Coreset's
R-CMD-check.ymlhas the same structure, and so the same bug.🤖 Generated with Claude Code