Fix Test Performance

[mstdokumaci]

Summary by CodeRabbit

• Tests
  • Improved expired-ticket verification by removing an unnecessary delay while preserving expiration checks.
  • Strengthened cache reclamation validation to ensure all expected values are deinitialized and no active nodes remain.
  • Updated write performance testing to use a production-like memory allocator and verify cleanup after completion.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 5a2d627f-91be-45dc-a275-4cc576559afd

📥 Commits

Reviewing files that changed from the base of the PR and between 09ef832 and d9f32a7.

📒 Files selected for processing (1)

• src/storage_engine/write_worker_perf_test.zig

🚧 Files skipped from review as they are similar to previous changes (1)

• src/storage_engine/write_worker_perf_test.zig

---

📝 Walkthrough

Walkthrough

The PR updates three tests. It removes an expiration delay, strengthens cache reclamation completion checks, and changes the write-worker performance test to use and deinitialize MemoryStrategy.

Changes

Test reliability and allocator lifecycle

Layer / File(s)	Summary
Test completion conditions src/authentication/ticket_exchange_test.zig, src/memory/lock_free_cache_leak_test.zig	The expired-ticket test removes its delay. The cache leak test also waits for zero active pool nodes.
Performance-test allocator lifecycle src/storage_engine/write_worker_perf_test.zig	The performance test uses MemoryStrategy for its general allocator and checks for leaks during cleanup.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

• mstdokumaci/zyncbase#161: Modifies allocator setup in the same performance test.
• mstdokumaci/zyncbase#173: Overlaps with the cache test and MemoryStrategy changes.
• mstdokumaci/zyncbase#180: Modifies imports and declarations in the same performance test.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the main purpose of the changes: improving test performance and execution behavior.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

---

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/storage_engine/write_worker_perf_test.zig`:
- Line 141: Update the defer leak check around prod_ms.deinit() to explicitly
panic when deinit does not return .ok, ensuring the check remains enforced in
ReleaseFast and ReleaseSmall builds.

🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: d8c9c07d-5910-4be5-9ebd-4c8b6d6789be

📥 Commits

Reviewing files that changed from the base of the PR and between 8ac926a and 09ef832.

📒 Files selected for processing (3)

• src/authentication/ticket_exchange_test.zig
• src/memory/lock_free_cache_leak_test.zig
• src/storage_engine/write_worker_perf_test.zig

💤 Files with no reviewable changes (1)

• src/authentication/ticket_exchange_test.zig