Fix rsync trying to copy SELinux xattrs and spamming the log#84
Open
gcoremans wants to merge 1 commit into
Open
Fix rsync trying to copy SELinux xattrs and spamming the log#84gcoremans wants to merge 1 commit into
gcoremans wants to merge 1 commit into
Conversation
SELinux contexts are stored as xattrs, but users are not allowed to set SELinux contexts. Thus, when rsync tries to do this, it produces one log message per file being copied, which ends up being one log message per file under node_modules; which completely spams your log which is very annoying. This fixes that by just telling rsync to ignore those xattrs. Fix as per https://unix.stackexchange.com/a/648651
Author
|
Tested and works on my end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SELinux contexts are stored as xattrs, but users are not allowed to set SELinux contexts. Thus, when rsync tries to do this, it produces one log message per file being copied, which ends up being one log message per file under node_modules; which completely spams your log which is very annoying. This fixes that by just telling rsync to ignore those xattrs.
Fix as per https://unix.stackexchange.com/a/648651
This shouldn't break anything, since it is failing to copy those xattrs anyway, we're just suppressing the error message by not trying. Even in a SELinux-enabled context (which this will never run in) you don't want those xattrs to be copied.