Repository navigation
Run ty in pre-commit and CI - #84
Merged
MLopez-Ibanez merged 1 commit intoOct 26, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #84 +/- ##
==========================================
- Coverage 77.81% 77.78% -0.04%
==========================================
Files 71 71
Lines 7577 7588 +11
Branches 1477 1477
==========================================
+ Hits 5896 5902 +6
- Misses 1310 1314 +4
- Partials 371 372 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
MLopez-Ibanez
force-pushed
the
contrib/moocore-19-ty-check
branch
4 times, most recently
from
October 25, 2026 09:59
debb585 to
25e5ead
Compare
MLopez-Ibanez
force-pushed
the
contrib/moocore-19-ty-check
branch
3 times, most recently
from
October 25, 2026 16:23
46d7011 to
e0da0c0
Compare
* .github/workflows/python.yml (type-check): New job. * .pre-commit-config.yaml (astral-sh/ty-pre-commit): New repo. Skip in pre-commit.ci * python/src/moocore/_docsubstitute.py (CallableT): New TypeVar. * python/src/moocore/_generate.py: Resolve ty diagnostics. * python/src/moocore/_moocore.py: Likewise. (MaximiseType): New TypeAlias. * python/src/moocore/_utils.py: Resolve ty diagnostics. Inputs of internal functions should be strict.
MLopez-Ibanez
force-pushed
the
contrib/moocore-19-ty-check
branch
from
October 25, 2026 17:25
e0da0c0 to
65b1032
Compare
Contributor
|
@ZijunLee Thank you for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
python/srcand resolve the existing diagnostics without broadly disabling type-checking rulesTesting
pre-commit run check-yaml --all-filespre-commit run pyproject-fmt --all-filespre-commit run ruff-format --all-filespre-commit run ruff --all-filespre-commit run ty --all-filestox -e typeAddresses the “run ty on CI/pre-commit” task in #19.