Repository navigation
Bump axios to 1.20.0 in cookbook project and recipes - #1214
Merged
Merged
Conversation
radumojic
approved these changes
Oct 5, 2026
popenta
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the pull request (what is new / what has changed)
The Cookbook TS verification workflow fails on every PR since seven high advisories were published for
axioson 2026-09-30, after the last green run (#1207, 2026-09-10). The cookbook project and the recipes pinaxios1.18.1:This bumps
axiosto 1.20.0, which fixes all seven and the moderate ones on the same range:testing/cookbook-ts/project/package.json:axiosgoes from1.18.1to1.20.0.testing/cookbook-ts/project/package-lock.json: only theaxiosentry changes (version, resolved, integrity, andform-data^4.0.5to^4.0.6; 4.0.6 is already the locked version).docs/sdk-and-tools/sdk-js/cookbook/: theaxiospin in the completepackage.jsongoes from1.18.1to1.20.0.verify-projects.mjsaudits these too, and readers copying a recipe would otherwise install a vulnerable version.1.20.0 is a minor release. Its only breaking-change notes are new names for the 413/422 status codes (the old ones stay as deprecated aliases) and a socket memory fix. The recipes only call
axios.get, and the SDKs accept it (sdk-dappneeds>=1.15.0,sdk-native-auth-client^1.10.0).The workflow will still fail after this PR, on a
bracesadvisory that has no fix yet:npm auditstarted reporting it.braces<=3.0.3 and has no patched version. 3.0.3 is the latestbracesrelease, so there is nothing to bump or override to yet.micromatch4 (latest 4.0.8 still requiresbraces ^3.0.3), via@multiversx/sdk-web-wallet-iframe-provider>@types/jest>expect>jest-message-utiland via@multiversx/sdk-dapp-ui>@stencil/react-output-target>ts-morph>fast-glob. It fails the project audit and the audit of the 8sdk-dapprecipes.bracesships a fix, it can be pinned throughoverrides, likebrace-expansionin Bump brace-expansion to 5.0.12 in cookbook project #1212.Checked locally:
npm ci --dry-runaccepts the lockfile, andnode ./testing/cookbook-ts/audit-project.mjsno longer reports anyaxiosadvisory, only GHSA-vfj7-8cjw-p6xm. With that advisory skipped locally (not part of this PR),./testing/cookbook-ts-ci.shpasses, building all 61 cookbook projects.Did you test the changes locally ?
Did you regenerate static/llms.txt and static/llms-full.txt ? (happens at build time)
Which category (categories) does this pull request belong to?