Skip to content

Audacity clip fade icons - #388

Open
saintmatthieu wants to merge 1 commit into
musescore:mainfrom
saintmatthieu:audacity-clip-fades
Open

saintmatthieu wants to merge 1 commit into
musescore:mainfrom
saintmatthieu:audacity-clip-fades

Conversation

@saintmatthieu

Copy link
Copy Markdown
Contributor

Goes with audacity/audacity#12557

Adds the fade handle icons, the same way the trim and stretch handles were.

  • I signed the CLA.
  • The title of the PR describes the problem it addresses.
  • Each commit's message describes its purpose and effects, and references the issue it resolves. If changes are extensive, there is a sequence of easily reviewable commits.
  • The code in the PR follows the coding rules.
  • The code compiles and runs on my machine, preferably after each commit individually. I have manually tested and verified that my changes fulfil their intended purpose.
  • No prior attempts to resolve this problem exist, or if they do, I listed them in my PR description and described how I avoided repeating past mistakes.
  • There are no unnecessary changes.

Complete only if applicable:

  • I created a unit test or vtest to verify the changes I made.
  • This PR was created using AI assistance; I have read, understood and complied following the guidelines for AI-assisted contributions. The AI tool(s) I used are listed below.

Claude Code w/ Opus 5.5

Build configuration

audacity: audacity/audacity/master
audacity platforms: linux_x64
musescore: musescore/MuseScore/main
musescore platforms: linux_x64

@saintmatthieu saintmatthieu self-assigned this Oct 26, 2026
@coderabbitai

coderabbitai Bot commented Oct 26, 2026

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 022766e and a4937e6.

Files ignored due to path filters: 1
  • framework/ui/data/MusescoreIcon.ttf is excluded by !**/*.ttf
Files selected for processing: 1
  • framework/ui/view/iconcodes.h

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

The IconCode::Code enum adds FADE_HANDLE_IN with value 0xF4CD and FADE_HANDLE_OUT with value 0xF4CE.

Priority: Low

Merge Risk: Minimal · up to a4937

No identified issue blocks merging the fade handle icon codes.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Title check Passed The title clearly identifies the addition of Audacity clip fade icons.
Description check Passed The description explains the fade icon change and its related Audacity pull request. It completes the checklist and lists the AI tool used. It does not include a Resolves: issue reference, but the d…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description explains the fade icon change and its related Audacity pull request. It completes the checklist and lists the AI tool used. It does not include a Resolves: issue reference, but the description is otherwise complete.

Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant