Fix laser pointer menu synchronization and state reset - #68
Conversation
Implemented `laser_mode_changed` PySide6 Signal in `InputManager` to broadcast changes to subscribers. Updated `toggle_laser_mode` to support explicit boolean targets and prevent redundant state toggles. Connected `TrayMenu`'s `laser_action` state to `laser_mode_changed`, ensuring tray menu checkmark remains synchronized with actual runtime state. Reset active laser mode on `reset_all_data()`. Added unit test coverage for signal emission and data reset handling.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
Fixes desynchronization between the TrayMenu "Laser Pointer" item and
InputManagerstate by introducinglaser_mode_changedsignal, supporting explicit boolean arguments intoggle_laser_mode, and resetting laser mode on data clear.PR created automatically by Jules for task 17407709580416347313 started by @mx57