Skip to content

docs: updated the styling ADR to include details about how to work wi… - #362

Merged
wesrisenmay-mx merged 1 commit into
masterfrom
wes/CT-2454
Aug 13, 2026
Merged

docs: updated the styling ADR to include details about how to work wi…#362
wesrisenmay-mx merged 1 commit into
masterfrom
wes/CT-2454

Conversation

@wesrisenmay-mx

Copy link
Copy Markdown
Collaborator

…th MXUI and CSS Modules

@Jameson13B Jameson13B left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me!

@codingLogan codingLogan left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be fine, and I will approve. I'll put my meeting comments here as well though.

What I don't want to happen with this change, is the frustration of feeling blocked, or forced to add more complexity to an otherwise simple and easy-to-review MR.

If there is a clear goal for an MR, and it doesn't strictly adhere to this rule, we should give some leeway if there is a documented goal to keep working in the area. For example, if a Jira ticket is exist to finish the work, and it's not a "someday" kind of Jira ticket. If the ticket is next sprint or right after this one, that's when we could allow a small step toward this.

Sometimes it's easier to work in small iterative steps to avoid conflicts and bloat for reviews, and we shouldn't discourage that way of working for the sake of an ADR, in my opinion.

@wesrisenmay-mx
wesrisenmay-mx merged commit 2a0d939 into master Aug 13, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants