Handle empty search queries - #488
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Bleve-backed search implementation to treat an empty search query as “default results”, returning only user-team–scoped documents and ranking those defaults by resource kind (teams first). It also adds a focused test suite for the empty-query behavior.
Changes:
- Add explicit handling for empty queries: return no defaults for users without teams; otherwise constrain results to the user’s team slugs.
- Extend boosting for empty queries to include
kind-based ranking (TEAM > APPLICATION > JOB > others). - Add unit tests covering empty-query defaults, ranking, team filtering within user teams, and no-team users.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/search/bleve.go | Implements empty-query default behavior (user-team scoping) and adds kind-based boosting for deterministic default ranking. |
| internal/search/bleve_test.go | Adds unit tests validating empty-query defaults, filtering behavior, no-team behavior, and ranking order. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
rtk go test ./internal/searchrtk mise run test:unitrtk mise run fmt