Skip to content

Remove native version and use native contract hash - #240

Merged
josesimoes merged 1 commit into
developfrom
new-assembly-format
Oct 12, 2026
Merged

josesimoes merged 1 commit into
developfrom
new-assembly-format

Conversation

@josesimoes

Copy link
Copy Markdown
Member

Description

  • Removed the AssemblyNativeVersion attribute from AssemblyInfo.cs.
  • Updated the nuspec description to reference the native contract hash.
  • Added the native contract hash tag to the nuspec tags.
  • Updated nanoFramework.CoreLibrary to 2.0.0-preview.63 in the nuspec, packages.config, nfproj and packages.lock.json files.

Motivation and Context

How Has This Been Tested?

Built by the CI pipeline of this PR.

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue with code or algorithm)
  • New feature (non-breaking change which adds functionality to code)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (add new Unit Test(s) or improved existing one(s), has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project (only if there are changes in source code).
  • My changes require an update to the documentation (there are changes that require the docs website to be updated).
  • I have updated the documentation accordingly (the changes require an update on the docs in this repo).
  • I have read the CONTRIBUTING document.
  • I have tested everything locally and all new and existing tests passed (only if there are changes in source code).
  • I have added new tests to cover my changes.

🤖 Generated with Claude Code

- Remove AssemblyNativeVersion attribute from AssemblyInfo.cs.
- Update nuspec description and add nfnc tag with native contract hash.
- Update nanoFramework.CoreLibrary to 2.0.0-preview.63.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: nanoframework/coderabbit/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 6e72f727-af68-4c1b-bca9-3f7ae03ddf79
📥 Commits

Reviewing files that changed from the base of the PR and between 89d46d2 and f5341a9.

📒 Files selected for processing (8)
  • System.IO.Ports/Properties/AssemblyInfo.cs
  • System.IO.Ports/System.IO.Ports.nfproj
  • System.IO.Ports/packages.config
  • System.IO.Ports/packages.lock.json
  • Tests/UnitTestsSerialPort/UnitTestsSerialPort.nfproj
  • Tests/UnitTestsSerialPort/packages.config
  • Tests/UnitTestsSerialPort/packages.lock.json
  • nanoFramework.System.IO.Ports.nuspec
💤 Files with no reviewable changes (1)
  • System.IO.Ports/Properties/AssemblyInfo.cs

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Summary

Summary by CodeRabbit

  • Compatibility
    • Updated the package’s device compatibility requirement to use the System.IO.Ports native contract hash.
    • Updated compatibility with the nanoFramework Core Library preview version used by the package and its serial port tests.

Walkthrough

The library and serial port test project now use nanoFramework.CoreLibrary preview 63. Package metadata uses a native contract hash placeholder instead of a native version and checksum. The assembly native version attribute was removed.

Changes

Ports package update

Layer / File(s) Summary
Update package dependencies and native contract metadata
System.IO.Ports/Properties/AssemblyInfo.cs, nanoFramework.System.IO.Ports.nuspec, System.IO.Ports/System.IO.Ports.nfproj, System.IO.Ports/packages.config, System.IO.Ports/packages.lock.json, Tests/UnitTestsSerialPort/*
The library and test project dependencies now use nanoFramework.CoreLibrary preview 63. The package description uses a native contract hash placeholder instead of a native version and checksum, and the package tags include nfnc-$nativeContractHash$. The assembly native version attribute was removed.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Other

Suggested labels: Area: Config-and-Build

Merge Risk: ⚪ Minimal · up to f5341

No actionable merge-blocking issue is established. Confirm the matching native declaration before releasing the package.

Pre-merge checks · Passed 4
Passed Passed checks (4 passed)
Check name Status Explanation
Title check Passed The title is concise, descriptive, directly related to the main changes, contains no issue references, and does not end with a full stop.
Description check Passed The description accurately explains the native contract hash changes, dependency updates, motivation, testing status, and affected files.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nfbot

nfbot commented Oct 12, 2026

Copy link
Copy Markdown
Member

⚠️ Native declaration update required!

The native contract hash of nanoFramework.System.IO.Ports has changed. The native declaration in nf-interpreter must be updated before this package can be released.

Previously published This build
Native contract hash 0x47A1E0DB 0x50FDCE58

👉 Tracking issue: nanoframework/Home#1924

The issue contains a link to the stubs artifact from this build and instructions for GitHub Copilot to perform the update.

@sonarqubecloud

Copy link
Copy Markdown

@josesimoes

Copy link
Copy Markdown
Member Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@josesimoes
josesimoes enabled auto-merge (squash) October 12, 2026 22:51
@josesimoes
josesimoes disabled auto-merge October 12, 2026 23:11
@josesimoes
josesimoes merged commit 22068ef into develop Oct 12, 2026
8 of 9 checks passed
@josesimoes
josesimoes deleted the new-assembly-format branch October 12, 2026 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants