[Retoocs]

Description

implement task state comparison on caseConditions

Implements NAE-2498

Dependencies

No new dependencies were introduced

Third party dependencies

No new dependencies were introduced

Blocking Pull requests

There are no dependencies on other PR

How Has Been This Tested?

By unit tests QueryLangEvaluatorTest

Test Configuration

Name	Tested on
OS	Ubuntu 24.04.1 LTS
Runtime	Java 11
Dependency Manager	Maven 3.6.3
Framework version	Spring Boot 2.7.8
Run parameters
Other configuration

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• My changes have been checked, personally or remotely, with @...
• I have commented my code, particularly in hard-to-understand areas
• I have resolved all conflicts with the target branch of the PR
• I have updated and synced my code with the target branch
• I have added tests that prove my fix is effective or that my feature works
• New and existing tests pass locally with my changes:
  • Lint test
  • Unit tests
  • Integration tests
• I have checked my contribution with code analysis tools:
  • SonarCloud
  • Snyk
• I have made corresponding changes to the documentation:
  • Developer documentation
  • User Guides
  • Migration Guides

Summary by CodeRabbit

• New Features
  • Task-state searches now support both equality and inequality comparisons for enabled and disabled states, including the existing not modifier. Search results reflect whether matching tasks are executable.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Organization UI
• Review profile: ASSERTIVE
• Plan: Advanced
• Run ID: b5ebd6f2-020f-4b74-84ea-fb75b0149683

📥 Commits

Reviewing files that changed from the base of the PR and between eaf0f35 and 944ec38.

📒 Files selected for processing: 3

• src/main/java/com/netgrif/application/engine/pfql/domain/antlr4/QueryLang.g4
• src/main/java/com/netgrif/application/engine/pfql/service/QueryLangEvaluator.java
• src/test/java/com/netgrif/application/engine/pfql/QueryLangTest.java

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

Task-state comparisons now accept EQ and NEQ for enabled and disabled states. The evaluator builds Elasticsearch queries on taskIds. Tests cover query output and search-result counts, including the optional NOT form.

Changes

Task-state comparisons

Layer / File(s)	Summary
Parse and evaluate task-state comparisons src/main/java/com/netgrif/application/engine/pfql/domain/antlr4/QueryLang.g4, src/main/java/com/netgrif/application/engine/pfql/service/QueryLangEvaluator.java, src/test/java/com/netgrif/application/engine/pfql/QueryLangTest.java	The grammar accepts EQ and NEQ. The evaluator builds Elasticsearch queries on taskIds based on the requested state and NOT modifier. Tests check enabled and disabled query output and search-result counts.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Feature

Merge Risk: 🔵 Low · up to 944ec

Task-state searches can misclassify cases with assigned tasks that later become disabled. This is a bounded search-result risk to consider before merging.

Pre-merge checks: 4 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 2 files. (1 skipped: 1 …	Write docstrings for the functions missing them to satisfy the coverage threshold.

Passed checks: 4 passed

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title clearly identifies the PFQL task-state support added by the pull request. It is concise and related to the main change.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 2 files. (1 skipped: 1 unsupported.)

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

• Fix all pre-merge checks with AI

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}