Repository navigation
Conversation
vrana
commented
Sep 28, 2026
vrana
commented
Member
- new feature
- BC break? no
- doc PR: latte: documented Extension::getAttributeContexts() docs#1097
Member
|
I'd like to take this, with one change in shape: let the built-in contexts be the default entries of the same table instead of the hard-coded checks, i.e. |
…s as JS, CSS or HTML
An extension can map attribute names, or prefixes ending with *, to
ContentType::JavaScript, Css or Html, e.g. 'x-on:*' => JavaScript or Tippy's
'data-tippy-content' => Html. A registered attribute is then escaped exactly like
on*, style or srcdoc: static values via the Escaper subType, dynamic attributes
(name={$x}) and n:attr via classifyAttributeType(), which now takes the map.
n:attr receives it as a compiled argument only when some context is registered.
Built-in contexts can't be overridden (on*, style, srcdoc and prefixes like s*
are rejected). The map is part of the configuration signature, so extensions
don't have to include it in getCacheKey().
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…tributes as JS, CSS or HTML The built-in contexts are the default entries of the same table (HtmlHelpers::AttributeContexts: on*, style, srcdoc) and extensions only add to it. enterHtmlAttribute() and classifyAttributeType() ask matchAttributeContext() alone; the hard-coded checks of on*, style and srcdoc are gone. Overriding a built-in stays an exception. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
vrana
force-pushed
the
attribute-contexts
branch
from
October 29, 2026 06:34
3bd7dfa to
bdb1f41
Compare
Member
Author
|
Makes sense, done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.