feat: enable custom openai endpoints for services like opper.ai - #16
Conversation
| } | ||
|
|
||
| if cfg.Provider == "openai" && cfg.Endpoint != "" { | ||
| opts = append(opts, upstream.SetOpenAIEndpoint(cfg.Endpoint)) |
There was a problem hiding this comment.
Pinned dependency lacks new API
This calls upstream.SetOpenAIEndpoint, but the module replacement remains pinned to the earlier immutable f6f84ac83bb5 revision. The PR description says networkteam/gollm#1 is required, but merging that upstream PR cannot alter this pinned version. Unless go.mod and go.sum are updated to a revision containing the API, the project will fail to compile with an undefined symbol.
Prompt To Fix With AI
This is a comment left during a code review.
Path: internal/llm/gollm/gollm.go
Line: 91
Comment:
**Pinned dependency lacks new API**
This calls `upstream.SetOpenAIEndpoint`, but the module replacement remains pinned to the earlier immutable `f6f84ac83bb5` revision. The PR description says `networkteam/gollm#1` is required, but merging that upstream PR cannot alter this pinned version. Unless `go.mod` and `go.sum` are updated to a revision containing the API, the project will fail to compile with an undefined symbol.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.There was a problem hiding this comment.
updated, please review again
|
networkteam/gollm#1 is merged, with two follow-ups on
To unblock this branch, bump the pin: That is all the P1 above amounts to — the ordering your description already calls out, not a defect in the change. The rest reads well: it mirrors the existing |
|
@bweinzierl Thx, the gollm PR for the fork is merged. Can you update the pinned version for this PR? |
Needs networkteam/gollm#1 first, otherwhise it breaks.
The PR is not safe to merge until the pinned gollm dependency is updated to a revision that provides
SetOpenAIEndpoint.Findings
Fix with agent prompt
Summary
This PR adds configurable base URLs for OpenAI-compatible LLM services.
llm.endpointto the configuration model and layered merge behavior.Reviews (1) · Last reviewed commit: "feat: enable custom openai endpoints for..."