Repository navigation
Add RFC 9271 attachment command aliases - #3710
Draft
user01010111 wants to merge 4 commits into
Draft
user01010111 wants to merge 4 commits into
user01010111 wants to merge 4 commits into
Conversation
Prepared with assistance from OpenAI Codex (GPT-6). Signed-off-by: user01010111 <12504630+user01010111@users.noreply.github.com>
|
A ZIP file with standard source tarball and another tarball with pre-built docs for commit 869c691 is temporarily available: NUT-tarballs-PR-3710.zip. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Replace "subclasses" with "derived classes" in libnutclient_misc(3) without changing the C++ API compatibility explanation. AppVeyor and the tarball build reject "subclasses". The newer local English dictionary accepts it; the tarball job's aspell-en 2020.12.07 dictionary reproduces the failure with the same local Aspell executable. The focused project spellcheck target fails before this change and passes after it with the CI dictionary, including the non-ASCII check. The affected manual builds and renders with the replacement wording. Signed-off-by: user01010111 <12504630+user01010111@users.noreply.github.com>
jimklimov
added
documentation
C++
refactor/fightwarn
|
✅ Build nut 2.8.5.5911-master completed (commit 066adae1f4 by @jimklimov)
|
|
✅ Build nut 2.8.5.5911-master completed (commit 066adae1f4 by @jimklimov) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add ATTACH, DETACH and GET NUMATTACH while retaining LOGIN, LOGOUT and GET NUMLOGINS. The aliases share the existing authentication and attachment accounting; duplicate errors follow the requested spelling, and HELP lists the preferred names. DETACH closes the entire connection.
Add preferred C/C++, Python and Perl API names and update upsmon to use the new attachment and count commands. Legacy fallback requires an exact unsupported-command reply; count queries also accept the INVALID-ARGUMENT response returned by older servers. Existing C++ subclasses and library SONAMEs are preserved. Implicit C and Python cleanup retains LOGOUT for prompt compatibility with older servers; explicit detach APIs negotiate the preferred command.
Draft implementation for #3637 while the protocol discussion continues.
Validation:
make distcheck-lightincluding build, tests, install and uninstall.Native Windows builds and client/server tests also passed, including immediate attachment release on old and new servers. Five existing Windows CppUnit branches are unimplemented, and the unrelated
become_user()subcheck requires root; all affected attachment and cleanup checks ran. Hosted CI has not run.Prepared with assistance from OpenAI Codex (GPT-6).