Skip to content

build(deps-dev): bump @types/node from 24.9.1 to 26.5.1 - #336

Closed
dependabot[bot] wants to merge 3 commits into
mainfrom
dependabot/npm_and_yarn/types/node-26.5.1
Closed

dependabot[bot] wants to merge 3 commits into
mainfrom
dependabot/npm_and_yarn/types/node-26.5.1

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Sep 17, 2026

Copy link
Copy Markdown
Contributor

Bumps @types/node from 24.9.1 to 26.5.1.

Commits

Most Recent Ignore Conditions Applied to This Pull Request
Dependency Name Ignore Conditions
@types/node [>= 25.0.a, < 25.1]

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 24.9.1 to 26.5.1.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

---
updated-dependencies:
- dependency-name: "@types/node"
  dependency-version: 26.5.1
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Sep 17, 2026
@dependabot
dependabot Bot requested review from a team as code owners September 17, 2026 20:34
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Sep 17, 2026
@codecov

codecov Bot commented Sep 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.30%. Comparing base (25dae02) to head (f1c3195).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #336   +/-   ##
=======================================
  Coverage   95.30%   95.30%           
=======================================
  Files         137      137           
  Lines        6388     6388           
  Branches     1679     1679           
=======================================
  Hits         6088     6088           
  Misses        300      300           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nevware21-bot nevware21-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by nevware21-bot

@nev21

nev21 commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

@copilot review the changes in this PR and in the PR #335 which was causing the typedoc publishing to fail and provide feedback on the path forward

Copilot AI commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

@copilot review the changes in this PR and in the PR #335 which was causing the typedoc publishing to fail and provide feedback on the path forward

I reviewed both PRs. #336 reintroduces the same change that #335 reverted (@types/node 24.9.1 -> 26.5.1 in core/root/shim + shrinkwrap). In #335, the docs publish failure was caused by TypeScript 5.2.2 + @types/node 26.x incompatibility (Typedoc build errors like missing IteratorObject / AsyncIteratorObject / BuiltinIteratorReturn).

Path forward:

  1. Do not merge build(deps-dev): bump @types/node from 24.9.1 to 26.5.1 #336 as-is (it is likely to break typedoc publishing again after merge).
  2. Keep @types/node pinned to 24.9.1 for now, and update Dependabot ignore rules for this package until TS is upgraded.
  3. If you want newer @types/node, do a dedicated compatibility PR: upgrade TypeScript/Typedoc first, then unpin @types/node, and validate npm run docs.
  4. Optional hardening: add a docs/typedoc check to PR CI so this cannot regress silently (current pages workflow runs on push to main).

Copilot AI requested a review from nev21 September 18, 2026 16:09
@nev21

nev21 commented Sep 20, 2026

Copy link
Copy Markdown
Contributor

@dependabot ignore this minor version

@nev21 nev21 closed this Sep 20, 2026
@dependabot @github

dependabot Bot commented on behalf of github Sep 20, 2026

Copy link
Copy Markdown
Contributor Author

OK, I won't notify you about version 26.5.x again, unless you re-open this PR.

@dependabot
dependabot Bot deleted the dependabot/npm_and_yarn/types/node-26.5.1 branch September 20, 2026 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants